GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.12] gh-105699: Re-enable the Multiple-Interpreters Stress Tests (gh-107572) by ericsnowcurrently · Pull Request #112483 · python/cpython

Conversation

ericsnowcurrently commented Nov 28, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

We had disabled them due to crashes they exposed, which have since been fixed.
(cherry picked from commit f9e3ff1)

(This is a repeat of gh-107783, which we had to revert.)

Issue: Crash During Subinterpreter Finalization #105699

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          [3.12] pythongh-105699: Re-enable the Multiple-Interpreters Stress Te…

d697fb0

…sts (pythongh-107572) (python#107783)

We had disabled them due to crashes they exposed, which have since been fixed.
(cherry picked from commit f9e3ff1)

Co-authored-by: Eric Snow <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: T. Wouters <[email protected]>

ericsnowcurrently added the skip news label

Nov 28, 2023

This was referenced Nov 28, 2023

Crash During Subinterpreter Finalization #105699

Closed

gh-105699: Re-enable the Multiple-Interpreters Stress Tests #107572

Merged

bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels

Nov 28, 2023


          Merge branch '3.12' into reenable-stress-tests-3.12

b19e0ef

ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Nov 28, 2023

bedevere-bot commented Nov 28, 2023

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit b19e0ef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Nov 28, 2023

ericsnowcurrently commented Nov 28, 2023

Copy link

Copy Markdown

Member Author

Looks like the various other backports didn't fix all the issues, though test_create_many_sequential seems to be passing consistently now. test_create_many_threaded is still crashing and we're still leaking references, but neither in CI. Notably, this hasn't been a problem on main. I guess there is at least one PR that we haven't backported that is making the difference.

buildbot: AMD64 Fedora Stable PR

https://buildbot.python.org/all/#/builders/52/builds/1218/steps/6/logs/stdio

test_create_many_threaded (test.test_interpreters.StressTests.test_create_many_threaded) ... mremap_chunk(): invalid pointer
Fatal Python error: Aborted
Current thread 0x00007f64956fc6c0 (most recent call first):
  File "<frozen importlib._bootstrap_external>", line 1186 in get_data
  File "<frozen importlib._bootstrap_external>", line 1086 in get_code
  File "<frozen importlib._bootstrap_external>", line 990 in exec_module
  File "<frozen importlib._bootstrap>", line 935 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1331 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1360 in _find_and_load
Extension modules: _xxsubinterpreters, _xxinterpchannels (total: 2)
1 test failed again:
    test_interpreters

buildbot: AMD64 FreeBSD14 PR

https://buildbot.python.org/all/#/builders/1255/builds/34/steps/5/logs/stdio

test_create_many_threaded (test.test_interpreters.StressTests.test_create_many_threaded) ... Debug memory block at address p=0x358a5428fc10: API 'r'
    1048 bytes originally requested
    The 7 pad bytes at p-7 are FORBIDDENBYTE, as expected.
    The 8 pad bytes at tail=0x358a54290028 are not all FORBIDDENBYTE (0xfd):
        at tail+0: 0x20 *** OUCH
        at tail+1: 0x06 *** OUCH
        at tail+2: 0x29 *** OUCH
        at tail+3: 0x54 *** OUCH
        at tail+4: 0x8a *** OUCH
        at tail+5: 0x35 *** OUCH
        at tail+6: 0x00 *** OUCH
        at tail+7: 0x00 *** OUCH
    Data at p: dd dd dd dd dd dd dd dd ... a8 90 7e 00 00 00 00 00
Enable tracemalloc to get the memory block allocation traceback
Fatal Python error: _PyMem_DebugRawRealloc: bad trailing pad byte
Python runtime state: initialized
Current thread 0x0000358a4db8fd00 (most recent call first):
  File "<frozen importlib._bootstrap_external>", line 752 in _compile_bytecode
  File "<frozen importlib._bootstrap_external>", line 1123 in get_code
  File "<frozen importlib._bootstrap_external>", line 990 in exec_module
  File "<frozen importlib._bootstrap>", line 935 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1331 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1360 in _find_and_load
  File "/home/buildbot/buildarea/pull_request.opsec-fbsd14/build/Lib/site.py", line 73 in <module>
  File "<frozen importlib._bootstrap>", line 488 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 994 in exec_module
  File "<frozen importlib._bootstrap>", line 935 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1331 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1360 in _find_and_load
Debug memory block at address p=0x358a3569aeb0: API '\xfd'
    8247625154782626045 bytes originally requested
    The 7 pad bytes at p-7 are not all FORBIDDENBYTE (0xfd):
        at p-7: 0xfd
        at p-6: 0xfd
        at p-5: 0xfd
        at p-4: 0xfd
        at p-3: 0xfd
        at p-2: 0xfd
        at p-1: 0xdd *** OUCH
    Because memory is corrupted at the start, the count of bytes requested
       may be bogus, and checking the trailing pad bytes may segfault.
    The 8 pad bytes at tail=0x7275a8eb9cceafad are Fatal Python error: Bus error
Current thread 0x0000358a4db8fd00 (most recent call first):
  File "<frozen importlib._bootstrap_external>", line 752 in _compile_bytecode
  File "<frozen importlib._bootstrap_external>", line 1123 in get_code
  File "<frozen importlib._bootstrap_external>", line 990 in exec_module
  File "<frozen importlib._bootstrap>", line 935 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1331 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1360 in _find_and_load
  File "/home/buildbot/buildarea/pull_request.opsec-fbsd14/build/Lib/site.py", line 73 in <module>
  File "<frozen importlib._bootstrap>", line 488 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line 994 in exec_module
  File "<frozen importlib._bootstrap>", line 935 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1331 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1360 in _find_and_load
Extension modules: _xxsubinterpreters, _xxinterpchannels (total: 2)
1 test failed again:
    test_interpreters

buildbot: AMD64 RHEL7 Refleaks PR

https://buildbot.python.org/all/#/builders/18/builds/1511/steps/5/logs/stdio

test_interpreters leaked [14, 14, 14] file descriptors, sum=42
1 test failed again:
    test_interpreters

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently commented Nov 28, 2023

Copy link

Copy Markdown

Member Author

I may bail out on re-enabling the stress tests on 3.12. They are more important on main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently marked this pull request as draft

November 28, 2023 17:35

bedevere-app Bot removed the awaiting core review label

Nov 28, 2023

ericsnowcurrently commented Nov 28, 2023

Copy link

Copy Markdown

Member Author

I suspect that at least gh-110709 would help, though I'm not sure if we'll backport that or not.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk commented Aug 9, 2024

Copy link

Copy Markdown

Member

Triage: is this backport still needed?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently commented Aug 9, 2024

Copy link

Copy Markdown

Member Author

I'm going to say no. :)

hugovk reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently closed this

Aug 9, 2024

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ericsnowcurrently commented Nov 28, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Nov 28, 2023

Uh oh!

ericsnowcurrently commented Nov 28, 2023

Uh oh!

ericsnowcurrently commented Nov 28, 2023

Uh oh!

ericsnowcurrently commented Nov 28, 2023

Uh oh!

hugovk commented Aug 9, 2024

Uh oh!

ericsnowcurrently commented Aug 9, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ericsnowcurrently commented Nov 28, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.