GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105699: Re-enable the Multiple-Interpreters Stress Tests (gh-107572) by miss-islington · Pull Request #107783 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

We had disabled them due to crashes they exposed, which have since been fixed.
(cherry picked from commit f9e3ff1)

Co-authored-by: Eric Snow [email protected]

  • Issue: Crash During Subinterpreter Finalization #105699

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently @miss-islington
pythongh-105699: Re-enable the Multiple-Interpreters Stress Tests (py…
7329b6f 
…thongh-107572)

We had disabled them due to crashes they exposed, which have since been fixed.
(cherry picked from commit f9e3ff1)

Co-authored-by: Eric Snow <[email protected]>
This was referenced Aug 8, 2023
Crash During Subinterpreter Finalization #105699
Closed
gh-105699: Re-enable the Multiple-Interpreters Stress Tests #107572
Merged
@bedevere-bot bedevere-bot added skip news awaiting review tests Tests in the Lib/test dir labels Aug 8, 2023
@ericsnowcurrently ericsnowcurrently assigned Yhg1s Aug 8, 2023
@ericsnowcurrently
ericsnowcurrently marked this pull request as draft August 8, 2023 18:35
@bedevere-bot bedevere-bot removed the awaiting review label Aug 8, 2023
@ericsnowcurrently

ericsnowcurrently commented Aug 8, 2023

Copy link
Copy Markdown
Member

Clearly something is off here. I didn't see any problems with the main branch. I'll investigate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
Merge branch '3.12' into backport-f9e3ff1-3.12
fa81823
@ambv

ambv commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

@ericsnowcurrently this currently passes after merging in the latest 3.12 state.
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member

@ericsnowcurrently: This PR was marked as a draft. What is its status?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review October 12, 2023 08:10
@bedevere-app bedevere-app Bot added the awaiting review label Oct 12, 2023
@Yhg1s
Merge branch '3.12' into backport-f9e3ff1-3.12
a8ff5c8
@ericsnowcurrently

ericsnowcurrently commented Nov 20, 2023

Copy link
Copy Markdown
Member

Does a8ff5c8 mean I can close this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s
Yhg1s approved these changes Nov 20, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 20, 2023
@Yhg1s

Yhg1s commented Nov 20, 2023

Copy link
Copy Markdown
Member

Does a8ff5c8 mean I can close this PR?

It means the 3.12 branch was merged into this PR, which I did to make sure the tests still pass. Is this PR still necessary? If not, then you could close it :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Nov 20, 2023

Copy link
Copy Markdown
Member

Ah, thanks for clarifying. I won't close this PR. 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently merged commit a4aac7d into python:3.12 Nov 27, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 27, 2023
@ericsnowcurrently

ericsnowcurrently commented Nov 27, 2023

Copy link
Copy Markdown
Member

I'll need to revert this. The problem is on FreeBSD.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Nov 27, 2023
@ericsnowcurrently
Revert "[3.12] pythongh-105699: Re-enable the Multiple-Interpreters S…
7cabbb7 
…tress Tests (pythongh-107572) (python#107783)"

This reverts commit a4aac7d.
@bedevere-app

bedevere-app Bot commented Nov 27, 2023

Copy link
Copy Markdown

GH-112474 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added a commit that referenced this pull request Nov 27, 2023
@ericsnowcurrently
[3.12] gh-105699: Revert gh-107783 "Re-enable the Multiple-Interprete…
ee7dc67 
…rs Stress Tests" (gh-112474)

Revert "[3.12] gh-105699: Re-enable the Multiple-Interpreters Stress Tests (gh-107572) (#107783)"

This reverts commit a4aac7d.

The stress tests are still failing on FreeBSD.
@ericsnowcurrently

ericsnowcurrently commented Nov 27, 2023

Copy link
Copy Markdown
Member

I'll retry this (with buildbots this time) once I've merged my other backport PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Nov 28, 2023
@miss-islington @ericsnowcurrently
@ambv @Yhg1s
[3.12] pythongh-105699: Re-enable the Multiple-Interpreters Stress Te…
d697fb0 
…sts (pythongh-107572) (python#107783)

We had disabled them due to crashes they exposed, which have since been fixed.
(cherry picked from commit f9e3ff1)

Co-authored-by: Eric Snow <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 28, 2023
[3.12] gh-105699: Re-enable the Multiple-Interpreters Stress Tests (gh-107572) #112483
Closed
@miss-islington
miss-islington deleted the backport-f9e3ff1-3.12 branch January 2, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @ericsnowcurrently @ambv @vstinner @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.