GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-112672: use `Tcl_Size` to avoid incompatible pointer type warnings by chrstphrchvz · Pull Request #112681 · python/cpython

Conversation

chrstphrchvz commented Dec 4, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Tkinter: incompatible pointer types warnings when built with Tcl 9 #112672

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

chrstphrchvz added 2 commits

December 3, 2023 17:59


          Cosmetic change to make the next change clearer

e4e403e


          Use Tcl_Size where needed

f8aee7a

bedevere-app Bot mentioned this pull request

Dec 4, 2023

Tkinter: incompatible pointer types warnings when built with Tcl 9 #112672

Closed


          There is a typo in the suggestion

f15bf1a

chrstphrchvz commented

Dec 4, 2023

View reviewed changes

Comment thread

Modules/_tkinter.c Outdated

Comment on lines 1211 to 1215

		void
		Tkapp_CallDeallocArgs(Tcl_Obj objv, Tcl_Obj objStore, int objc)
		Tkapp_CallDeallocArgs(Tcl_Obj objv, Tcl_Obj objStore, Tcl_Size objc)
		{
		int i;
		Tcl_Size i;
		for (i = 0; i < objc; i++)

chrstphrchvz Dec 4, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~Watch out for conflict with #112679.~~ I wonder if this function should iterate backwards over objv[] since it is deallocating.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Merge branch 'main' into patch-112672

feb8c90

encukou added the topic-tkinter label

Dec 6, 2023

serhiy-storchaka self-requested a review

December 6, 2023 14:28


          Merge branch 'main' into patch-112672

5fcba9d

serhiy-storchaka approved these changes

May 31, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The warnings are gone (and they are not innocent warnings, they are errors). What is left to do here to make it a non-draft?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added the awaiting merge label

May 31, 2024


          Merge branch 'main' into patch-112672

958e45b

serhiy-storchaka mentioned this pull request

Jun 4, 2024

Tkinter fails to build with Tcl 9.0 due to Tcl_AppInit() undeclared #104363

Closed

serhiy-storchaka added 2 commits

June 4, 2024 18:58


          Add missing in Tcl 9.0 declaration of deprecated Tcl_AppInit().

c5801b3


          Add a NEWS entry.

131eca9

serhiy-storchaka marked this pull request as ready for review

June 4, 2024 16:05

bedevere-app Bot added awaiting review and removed awaiting merge labels

Jun 4, 2024

serhiy-storchaka merged commit e079935 into python:main

Jun 4, 2024

bedevere-app Bot removed the awaiting review label

Jun 4, 2024

barneygale pushed a commit to barneygale/cpython that referenced this pull request

Jun 5, 2024


          pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)

faefa59

* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka added the needs backport to 3.13 only security fixes label

Jun 7, 2024

miss-islington-app Bot commented Jun 7, 2024

Copy link

Copy Markdown

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 7, 2024


          pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)

5219a44

* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

(cherry picked from commit e079935)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Jun 7, 2024

Copy link

Copy Markdown

GH-120208 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jun 7, 2024

serhiy-storchaka added the needs backport to 3.12 only security fixes label

Jun 7, 2024

miss-islington-app Bot commented Jun 7, 2024

Copy link

Copy Markdown

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 7, 2024


          pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)

dcdc077

* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

(cherry picked from commit e079935)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Jun 7, 2024

Copy link

Copy Markdown

GH-120209 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Jun 7, 2024

serhiy-storchaka added a commit that referenced this pull request

Jun 7, 2024


          [3.13] gh-112672: Fix builtin Tkinter with Tcl 9.0 (GH-112681) (GH-12…

f0165d0

…0208)

* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

(cherry picked from commit e079935)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka added a commit that referenced this pull request

Jun 7, 2024


          [3.12] gh-112672: Fix builtin Tkinter with Tcl 9.0 (GH-112681) (GH-12…

ec139c8

…0209)

* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

(cherry picked from commit e079935)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024


          pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)

ee86795

* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

Co-authored-by: Serhiy Storchaka <[email protected]>

thunze mentioned this pull request

Sep 15, 2025

Build failure: ceph NixOS/nixpkgs#442652

Closed

3 tasks done

chrstphrchvz deleted the patch-112672 branch

November 12, 2025 20:49

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

chrstphrchvz commented Dec 4, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrstphrchvz Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jun 7, 2024

Uh oh!

bedevere-app Bot commented Jun 7, 2024

Uh oh!

miss-islington-app Bot commented Jun 7, 2024

Uh oh!

bedevere-app Bot commented Jun 7, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chrstphrchvz commented Dec 4, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

chrstphrchvz Dec 4, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.