GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110383: Remove references to removed popen[234] by shenanigansd · Pull Request #112783 · python/cpython

Conversation

@shenanigansd

@shenanigansd shenanigansd commented Dec 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Continues #110383
Originally reported in https://mail.python.org/archives/list/[email protected]/thread/4AYZNSW3RB3DNT5C7JEE6RCESBWIKZTD/

Remove recommendations for migrating away from os.popen2, os.popen3, os.popen4, and popen2, which haven't existed since Python 2.7.

Leaves the recommendations for os.popen, which does still exist.

  • Issue: Issues from [email protected] #110383

📚 Documentation preview 📚: https://cpython-previews--112783.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shenanigansd
Drop references to popen[234] in subprocess docs
4757b7b 
These functions were removed in Python 3.

Signed-off-by: Bradley Reynolds <[email protected]>
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 6, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2023
Issues from [email protected] #110383
Closed
@tonybaloney

tonybaloney commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Would this section also need to be reviewed? https://github.com/python/cpython/blob/main/Doc/faq/library.rst?plain=1#L538-L582
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shenanigansd
Remove outdated comments in FAQ
f84d6d4 
They have been commented out since 2009: 9e4ff75
@shenanigansd

shenanigansd commented Dec 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Upon review, that section was commented out in 2009 (9e4ff75)
If it hasn't been needed since then, we should probably go ahead and remove it.

I've gone ahead and removed it in f84d6d4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shenanigansd
Merge branch 'main' into br/remove-references-to-popen+
0c95a3c
encukou
encukou approved these changes May 30, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 30, 2024
@encukou
Merge branch 'main' into br/remove-references-to-popen+
d930134
@encukou
encukou enabled auto-merge (squash) May 30, 2024 12:03
@encukou
encukou merged commit b1374aa into python:main May 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 30, 2024
@shenanigansd
shenanigansd deleted the br/remove-references-to-popen+ branch May 30, 2024 15:22
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@shenanigansd @estyxx
pythongh-110383: Remove references to removed popen[234] (pythonGH-11…
8b82168 
…2783)


Signed-off-by: Bradley Reynolds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@shenanigansd @tonybaloney @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.