GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-110109: Move tests for pathlib ABCs to new module. by barneygale · Pull Request #112904 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Dec 9, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These tests will be used in a standalone PyPI package.

Followup to #112881

  • Issue: User-defined virtual path objects #110109

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@barneygale
pythonGH-110109: Move tests for pathlib ABCs to new module.
a85a5da
These tests will be used in a standalone PyPI package.
@barneygale barneygale added tests Tests in the Lib/test dir skip news topic-pathlib labels Dec 9, 2023
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 9, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 9, 2023
User-defined virtual path objects #110109
Closed
8 tasks done
@barneygale
barneygale requested a review from ambv December 11, 2023 12:09
@barneygale
Don't run ABC test units from test_pathlib
eddb352
@barneygale

barneygale commented Dec 14, 2023

Copy link
Copy Markdown
Contributor Author

Same test count with and without this patch:

Ran 827 tests in 7.432s  # before
Ran 827 tests in 7.780s  # after
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@barneygale
barneygale merged commit d91e43e into python:main Dec 16, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 16, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@barneygale @aisk
pythonGH-110109: Move tests for pathlib ABCs to new module. (python#1…
c972eaf
…12904)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@barneygale @Glyphack
pythonGH-110109: Move tests for pathlib ABCs to new module. (python#1…
6f2d606
…12904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.