GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112962: in dis module, put cache information in the Instruction instead of creating fake Instructions to represent it by iritkatriel · Pull Request #113016 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Dec 12, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixed #112962.

  • Issue: Make cache information a part of dis.Instruction #112962

📚 Documentation preview 📚: https://cpython-previews--113016.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-112962: in dis module, put cache information in the Instruct…
ae7dbca 
…ion instead of creating fake Instructions to represent it
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 12, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 12, 2023
Make cache information a part of dis.Instruction #112962
Closed
@iritkatriel
add news
4f0f360
@iritkatriel
iritkatriel requested a review from markshannon December 12, 2023 16:33
iritkatriel added 3 commits December 12, 2023 17:04
@iritkatriel
rename cache_format to cache_info and make it a field of _Instruction…
f781235 
…. Document it.
@iritkatriel
Merge remote-tracking branch 'upstream/main' into cache-on-instruction
bd9c45a
@iritkatriel
fix test_code and test_compile
744f403
iritkatriel
iritkatriel commented Dec 12, 2023
View reviewed changes
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel and others added 3 commits December 12, 2023 20:24
@iritkatriel
tweaks
a42ec5b
@iritkatriel
fix test util
12008a2
@iritkatriel
Merge branch 'main' into cache-on-instruction
3649fe9
markshannon
markshannon approved these changes Dec 13, 2023
View reviewed changes
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 13, 2023
iritkatriel and others added 2 commits December 13, 2023 11:29
@iritkatriel
clarify change in get_instructions
730c435
@iritkatriel
Merge branch 'main' into cache-on-instruction
723226e
@iritkatriel
iritkatriel enabled auto-merge (squash) December 13, 2023 11:47
@iritkatriel
iritkatriel merged commit 428c981 into python:main Dec 13, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 13, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-112962: in dis module, put cache information in the Instruct…
a1407ac 
…ion instead of creating fake Instructions to represent it (python#113016)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-112962: in dis module, put cache information in the Instruct…
d7505b1 
…ion instead of creating fake Instructions to represent it (python#113016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make cache information a part of dis.Instruction

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iritkatriel @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.