GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on Windows by serhiy-storchaka · Pull Request #113049 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 13, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: os.chmod() does not follow symlinks on Windows #59616

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement OS-windows labels Dec 13, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 13, 2023
os.chmod() does not follow symlinks on Windows #59616
Closed
@serhiy-storchaka
pythongh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod(…
0d117a1 
…) on Windows
@serhiy-storchaka
serhiy-storchaka force-pushed the win-chmod-follow-symlinks branch from 15c667b to 0d117a1 Compare December 13, 2023 11:50
serhiy-storchaka added 4 commits December 13, 2023 15:45
@serhiy-storchaka
Fix tests on Windows.
a69e8cc
@serhiy-storchaka
Fix clinic.
167c00d
@serhiy-storchaka
Fix clinic and Windows again.
ac3ed22
@serhiy-storchaka
Update docs.
62a69c9
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review December 13, 2023 15:09
@serhiy-storchaka
serhiy-storchaka requested review from AlexWaygood and erlend-aasland as code owners December 13, 2023 15:09
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 13, 2023
serhiy-storchaka added 3 commits December 13, 2023 17:10
@serhiy-storchaka
Run all tests.
aebcd68
@serhiy-storchaka
What's New.
1f47f6a
@serhiy-storchaka
Revert auditing changes.
3f3e25a
@AlexWaygood
AlexWaygood removed their request for review December 13, 2023 16:51
serhiy-storchaka added 2 commits December 13, 2023 20:22
@serhiy-storchaka
Fix test_shutil on Windows.
5f5f826
@serhiy-storchaka
Lie to Sphinx.
64883ac
erlend-aasland
erlend-aasland reviewed Dec 13, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two PEP-7 nits and two cases where we should be explicitly ignoring the return value (-Wunused-result).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka and others added 4 commits December 14, 2023 08:27
@serhiy-storchaka @erlend-aasland
Apply suggestions from code review
37725be 
Co-authored-by: Erlend E. Aasland <[email protected]>
@serhiy-storchaka
Merge branch 'main' into win-chmod-follow-symlinks
b1b2914
@serhiy-storchaka
Merge branch 'main' into win-chmod-follow-symlinks
fbf0f88
@serhiy-storchaka
Add more warnings about the default value.
17b0faf
@serhiy-storchaka
serhiy-storchaka merged commit 29f7eb4 into python:main Dec 14, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 14, 2023
@serhiy-storchaka
serhiy-storchaka deleted the win-chmod-follow-symlinks branch December 14, 2023 11:28
corona10 pushed a commit to corona10/cpython that referenced this pull request Dec 15, 2023
@serhiy-storchaka @corona10
pythongh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod(…
4f84b76 
…) on Windows (pythonGH-113049)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod(…
ec13685 
…) on Windows (pythonGH-113049)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod(…
2f01618 
…) on Windows (pythonGH-113049)
This was referenced Nov 12, 2026
Path.chmod() silently fails on Windows when archive bit is cleared and follow_symlinks=True #140774
Closed
gh-140774: Fix clearing the read-only file attribute on Windows #154852
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.