GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-86179: Avoid making case-only changes when calculating realpath() during initialization by zooba · Pull Request #113077 · python/cpython

Conversation

@zooba

@zooba zooba commented Dec 14, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: venv on Windows with symlinks is broken if invoked with -I #86179

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-86179: Avoid making case-only changes when calculating realp…
a56fac8 
…ath() during initialization
@zooba zooba added the skip news label Dec 14, 2023
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 14, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 14, 2023
venv on Windows with symlinks is broken if invoked with -I #86179
Closed
@zooba

zooba commented Dec 14, 2023

Copy link
Copy Markdown
Member Author

!buildbot windows
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 14, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit a56fac8 🤖

The command will test the builders whose names match following regular expression: windows

The builders matched are:

  • AMD64 Windows11 Bigmem PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Windows10 PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows11 Non-Debug PR
  • ARM64 Windows PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka reviewed Dec 14, 2023
View reviewed changes
Comment thread Modules/getpath.c
}
}
result = PyUnicode_FromWideChar(p, len);
if (CompareStringOrdinal(path, (int)pathlen, p, len, TRUE) == CSTR_EQUAL) {

@serhiy-storchaka serhiy-storchaka Dec 14, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can pathlen be larger than INT_MAX?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zooba zooba Dec 14, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, and if it is, we'll have failed earlier because the API can't handle more than 32K worth of path.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
zooba merged commit fd81afc into python:main Dec 14, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 14, 2023
@zooba
zooba deleted the gh-86179 branch December 14, 2023 15:18
corona10 pushed a commit to corona10/cpython that referenced this pull request Dec 15, 2023
@zooba @corona10
pythongh-86179: Avoid making case-only changes when calculating realp…
7a7211e 
…ath() during initialization (pythonGH-113077)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@zooba @aisk
pythongh-86179: Avoid making case-only changes when calculating realp…
887a49c 
…ath() during initialization (pythonGH-113077)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@zooba @Glyphack
pythongh-86179: Avoid making case-only changes when calculating realp…
ecaf5fd 
…ath() during initialization (pythonGH-113077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zooba @bedevere-bot @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.