GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113191: Add support of os.fchmod() on Windows by serhiy-storchaka · Pull Request #113192 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 15, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also support a file descriptor in os.chmod().

  • Issue: Add os.fchmod() on Windows #113191

📚 Documentation preview 📚: https://cpython-previews--113192.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-113191: Add support of os.fchmod() on Windows
94809bc 
Also support a file descriptor in os.chmod().
@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement OS-windows labels Dec 15, 2023
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 15, 2023
Add os.fchmod() on Windows #113191
Closed
@serhiy-storchaka
serhiy-storchaka marked this pull request as draft December 15, 2023 19:49
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 15, 2023
serhiy-storchaka added 2 commits December 15, 2023 21:51
@serhiy-storchaka
Fix typos.
d9d3b08
@serhiy-storchaka
Fixes.
c9d364b
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review December 16, 2023 12:45
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 16, 2023
serhiy-storchaka added 3 commits December 16, 2023 18:29
@serhiy-storchaka
Merge branch 'main' into win-fchmod
1175c46
@serhiy-storchaka
Redefine PATH_HAVE_FCHMOD on Windows.
dbc5663
@serhiy-storchaka
Fix tabs.
5e2601d
zooba
zooba approved these changes Dec 18, 2023
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 18, 2023
@serhiy-storchaka
Merge branch 'main' into win-fchmod
bdc8625
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) December 23, 2023 14:15
@serhiy-storchaka
Merge branch 'main' into win-fchmod
24d912b
@serhiy-storchaka
serhiy-storchaka merged commit 1f06bae into python:main Dec 24, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 24, 2023
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@serhiy-storchaka @ryan-duve
pythongh-113191: Add support of os.fchmod() on Windows (pythonGH-113192)
6e5b5b1 
Also support a file descriptor in os.chmod().
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@serhiy-storchaka @kulikjak
pythongh-113191: Add support of os.fchmod() on Windows (pythonGH-113192)
32776ca 
Also support a file descriptor in os.chmod().
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-113191: Add support of os.fchmod() on Windows (pythonGH-113192)
5956db1 
Also support a file descriptor in os.chmod().
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-113191: Add support of os.fchmod() on Windows (pythonGH-113192)
f031e5f 
Also support a file descriptor in os.chmod().
@serhiy-storchaka
serhiy-storchaka deleted the win-fchmod branch July 1, 2026 16:51
This was referenced Nov 12, 2026
Path.chmod() silently fails on Windows when archive bit is cleared and follow_symlinks=True #140774
Closed
gh-140774: Fix clearing the read-only file attribute on Windows #154852
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.