GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113202: Add a strict option to itertools.batched() by rhettinger · Pull Request #113203 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Dec 16, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add a strict option to itertools.batched() #113202

📚 Documentation preview 📚: https://cpython-previews--113203.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rhettinger added 3 commits December 15, 2023 17:58
@rhettinger
Add a strict test to batched().
ec578c3
@rhettinger
Update the pure python rough equivalent code
1f34769
@rhettinger
Add blurb
0c87791
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 16, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 16, 2023
Add a strict option to itertools.batched() #113202
Closed
rhettinger and others added 2 commits December 15, 2023 18:13
@rhettinger
Merge branch 'main' into batched_strict
4dd9d37
@rhettinger
Update reshape() to use the strict option.
580cfd1
hauntsaninja
hauntsaninja approved these changes Dec 16, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature!

One possible nit could be a more explicit error message. I checked what more_itertools.chunked does and based the suggestion off of it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/itertoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 16, 2023
@rhettinger
rhettinger merged commit 1583c40 into python:main Dec 16, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 16, 2023
@bbayles bbayles mentioned this pull request Jan 2, 2024
Add a strict argument for batched more-itertools/more-itertools#784
Merged
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@rhettinger @aisk
pythongh-113202: Add a strict option to itertools.batched() (pythongh…
b4e8ed8 
…-113203)
@max-muoto max-muoto mentioned this pull request Jul 2, 2024
Add missing strict argument for itertools.batched (3.13) python/typeshed#12256
Merged
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@rhettinger @Glyphack
pythongh-113202: Add a strict option to itertools.batched() (pythongh…
7786f3f 
…-113203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rhettinger @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.