GeezerVison is showing github.com — GH-110109: pathlib tests: store base directory as test class attribute by barneygale · Pull Request #113221 · python/cpython
Conversation
barneygale
commented
Dec 16, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Store the test base directory as a class attribute named base rather than module constants named BASE.
The base directory is a local file path, and therefore not ideally suited to the pathlib ABC tests. In a future commit we'll change its value in test_pathlib_abc.py such that it points to a totally fictitious path, which will help to ensure we're not touching the local filesystem.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…tribute
Store the test base directory as a class attribute named `base` rather than
module constants named `BASE`.
The base directory is a local file path, and therefore not ideally suited
to the pathlib ABC tests. In a future commit we'll change its value in
`test_pathlib_abc.py` such that it points to a totally fictitious path.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…tribute (python#113221)
Store the test base directory as a class attribute named `base` rather than
module constants named `BASE`.
The base directory is a local file path, and therefore not ideally suited
to the pathlib ABC tests. In a future commit we'll change its value in
`test_pathlib_abc.py` such that it points to a totally fictitious path, which
will help to ensure we're not touching the local filesystem.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…tribute (python#113221)
Store the test base directory as a class attribute named `base` rather than
module constants named `BASE`.
The base directory is a local file path, and therefore not ideally suited
to the pathlib ABC tests. In a future commit we'll change its value in
`test_pathlib_abc.py` such that it points to a totally fictitious path, which
will help to ensure we're not touching the local filesystem.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.