GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113157 gh-89519: Fix method descriptors by rhettinger · Pull Request #113233 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Dec 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix yet another problem created by classmethod descriptor chaining. This completes the work in gh-89519, fixes the bug reported in gh-113157, and get us back to the stable and correct semantics in Python 3.9.

There is still an open question about what if anything to do for Python 3.11 and Python 3.12. We can' t backport this without breaking something else.

  • Issue: Changed behavior of <instancemethod>.__get__ in Python 3.11 #113157

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhettinger
pythongh-113157 pythongh-89519 Restore behaviors before classmethod d…
172f34a 
…escriptor chaining was introduced.
@rhettinger rhettinger added the skip news label Dec 17, 2023
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 17, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 17, 2023
Changed behavior of <instancemethod>.__get__ in Python 3.11 #113157
Closed
@rhettinger rhettinger changed the title gh-113157 gh-89519: Restore behaviors before classmethod descriptor chaining was introduced gh-113157 gh-89519: Fix method descriptors Dec 17, 2023
@mschmitzer

mschmitzer commented Dec 18, 2023

Copy link
Copy Markdown

I think there's a typo in the commit message, you probably meant to reference gh-113157 ?
rhettinger reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger merged commit d058eae into python:main Dec 21, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 21, 2023
facebook-github-bot pushed a commit to facebookincubator/MetaPython that referenced this pull request Dec 22, 2023
@itamaro @facebook-github-bot
gh-89519 & gh-113157 (Remove classmethod descriptor chaining, depreca…
f508768 
…ted since 3.11)

Summary:
backport upstream PRs python/cpython#110163 and python/cpython#113233

upstream issues: python/cpython#89519 (Calling help executes classmethod property decorated methods) and python/cpython#113157 (Changed behavior of <instancemethod>.__get__ in Python 3.11)

upstream commits: [`7f9a99e8549b792662f2cd28bf38a4d4625bd402`](python/cpython@7f9a99e) and [`d058eaeed44766a8291013b275ad22f153935d3b`](python/cpython@d058eae)

Reviewed By: aleivag

Differential Revision: D52014322

fbshipit-source-id: 87de6d9587bd9cc49f053ca340adfc469b041f91
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@rhettinger @ryan-duve
pythongh-113157 pythongh-89519: Fix method descriptors (pythongh-113233)
278a514 
Restore behaviors before classmethod descriptor chaining was introduced.
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@rhettinger @kulikjak
pythongh-113157 pythongh-89519: Fix method descriptors (pythongh-113233)
b9f2300 
Restore behaviors before classmethod descriptor chaining was introduced.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@rhettinger @aisk
pythongh-113157 pythongh-89519: Fix method descriptors (pythongh-113233)
ead59a8 
Restore behaviors before classmethod descriptor chaining was introduced.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@rhettinger @Glyphack
pythongh-113157 pythongh-89519: Fix method descriptors (pythongh-113233)
602f955 
Restore behaviors before classmethod descriptor chaining was introduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rhettinger @mschmitzer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.