GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113119: Fix the macOS framework installer build by gpshead · Pull Request #113268 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Dec 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: subprocess.Popen can pass incomplete environment when posix_spawn is used #113119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
pythongh-113117: Fix the macOS framework installer build
770fe16
@bedevere-app bedevere-app Bot mentioned this pull request Dec 19, 2023
Add support for posix_spawn call in subprocess.Popen with close_fds=True #113117
Closed
@gpshead gpshead added skip news OS-mac type-bug An unexpected behavior, bug, or error labels Dec 19, 2023
@gpshead
fix the fix? :)
737ffae
@gpshead gpshead changed the title gh-113117: Fix the macOS framework installer build gh-113119: Fix the macOS framework installer build Dec 19, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 17, 2023
subprocess.Popen can pass incomplete environment when posix_spawn is used #113119
Closed
@gpshead
gpshead marked this pull request as ready for review December 19, 2023 04:54
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 19, 2023
@gpshead
gpshead requested a review from ned-deily December 19, 2023 04:55
@gpshead

gpshead commented Dec 19, 2023

Copy link
Copy Markdown
Member Author

Related: since this didn't come up in testing for the original change, it sounds like we're missing --enable-framework in either CI or buildbots?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead added 3.13 only security fixes release-blocker labels Dec 19, 2023
ned-deily
ned-deily approved these changes Dec 19, 2023
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 19, 2023
@gpshead

gpshead commented Dec 19, 2023

Copy link
Copy Markdown
Member Author

I manually tested that building works on a mac with a configure --enable-framework - FWIW there appear to be a pile of tests that do not pass in framework builds regardless of this (looks environment related when launching python as a child process).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
gpshead merged commit c895403 into python:main Dec 19, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 19, 2023
@gpshead
gpshead deleted the issue113117-macos-framework branch December 19, 2023 05:18
@gpshead gpshead added release-blocker and removed release-blocker labels Dec 19, 2023
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@gpshead @ryan-duve
pythongh-113119: Fix the macOS framework installer build (python#113268)
ef388a4 
`--enable-framework` builds were failing.  we apparently do not have good CI & buildbot coverage here.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@gpshead @aisk
pythongh-113119: Fix the macOS framework installer build (python#113268)
7fa9a0a 
`--enable-framework` builds were failing.  we apparently do not have good CI & buildbot coverage here.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@gpshead @Glyphack
pythongh-113119: Fix the macOS framework installer build (python#113268)
7a9581b 
`--enable-framework` builds were failing.  we apparently do not have good CI & buildbot coverage here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13 only security fixes OS-mac release-blocker skip news type-bug An unexpected behavior, bug, or error

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gpshead @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.