GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113332: Simplify calls to SSL_(CTX_)set_verify in _ssl.c by davidben · Pull Request #113333 · python/cpython

Conversation

@davidben

@davidben davidben commented Dec 20, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

_ssl.c currently tries to preserve the verification callback, but at no point does it ever set one. Just pass in NULL.

  • Issue: _ssl.c calls SSL_CTX_get_verify_callback unnecessarily #113332

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@davidben
pythongh-113332: Simplify calls to SSL_(CTX_)set_verify in _ssl.c
9689750
_ssl.c currently tries to preserve the verification callback, but at no
point does it ever set one. Just pass in NULL.
@bedevere-app bedevere-app Bot added the awaiting review label Dec 20, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 20, 2023
_ssl.c calls SSL_CTX_get_verify_callback unnecessarily #113332
Closed
@alex alex added the skip news label Dec 26, 2023
alex
alex approved these changes Dec 26, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 26, 2023
@alex
alex merged commit af2b8f6 into python:main Dec 26, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 26, 2023
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@davidben @kulikjak
pythongh-113332: Simplify calls to SSL_(CTX_)set_verify in _ssl.c (py…
6278bb5
…thon#113333)

_ssl.c currently tries to preserve the verification callback, but at no
point does it ever set one. Just pass in NULL.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@davidben @aisk
pythongh-113332: Simplify calls to SSL_(CTX_)set_verify in _ssl.c (py…
3aff9f0
…thon#113333)

_ssl.c currently tries to preserve the verification callback, but at no
point does it ever set one. Just pass in NULL.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@davidben @Glyphack
pythongh-113332: Simplify calls to SSL_(CTX_)set_verify in _ssl.c (py…
6cf5ed5
…thon#113333)

_ssl.c currently tries to preserve the verification callback, but at no
point does it ever set one. Just pass in NULL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex alex alex approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@davidben @alex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.