GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113336: Remove the 'version' directive from Argument Clinic by erlend-aasland · Pull Request #113341 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 20, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The 'version' directive was introduced with gh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.

  • Issue: Argument Clinic: remove the 'version' directive #113336

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-113336: Remove the 'version' directive from Argument Clinic
413e64c 
The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
@erlend-aasland erlend-aasland added the skip news label Dec 20, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 20, 2023
Argument Clinic: remove the 'version' directive #113336
Closed
@erlend-aasland
erlend-aasland marked this pull request as ready for review December 20, 2023 23:13
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner December 20, 2023 23:13
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 20, 2023
AlexWaygood
AlexWaygood approved these changes Dec 20, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm a tiny bit worried about Chesterton's fence here. I'd love it if @serhiy-storchaka could also take a look!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji erlend-aasland reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 20, 2023
serhiy-storchaka
serhiy-storchaka approved these changes Dec 21, 2023
View reviewed changes
@erlend-aasland

erlend-aasland commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews, Alex and Serhiy.
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit fae096c into python:main Dec 21, 2023
@erlend-aasland
erlend-aasland deleted the clinic/remove-version-directive branch December 21, 2023 12:10
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 21, 2023
@erlend-aasland erlend-aasland mentioned this pull request Dec 21, 2023
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
Closed
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@erlend-aasland @ryan-duve
pythongh-113336: Remove the 'version' directive from Argument Clinic (p…
8c989c8 
…ython#113341)

The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@erlend-aasland @kulikjak
pythongh-113336: Remove the 'version' directive from Argument Clinic (p…
bcd732b 
…ython#113341)

The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@erlend-aasland @aisk
pythongh-113336: Remove the 'version' directive from Argument Clinic (p…
8c59ec2 
…ython#113341)

The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@erlend-aasland @Glyphack
pythongh-113336: Remove the 'version' directive from Argument Clinic (p…
88f4f54 
…ython#113341)

The 'version' directive was introduced with pythongh-63929 in Nov 2013. It has
not been in use in the CPython code base, and the 'version' variable has
never been bumped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @serhiy-storchaka @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.