GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-113317: Clean up Argument Clinic global namespace by erlend-aasland · Pull Request #113414 · python/cpython

Conversation

erlend-aasland commented Dec 22, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Split up clinic.py by establishing libclinic as a support package for
Argument Clinic. Get rid of clinic.py globals by either making them
class members, or by putting them into libclinic.

Move INCLUDE_COMMENT_COLUMN to BlockPrinter
Move NO_VARARG to CLanguage
Move formatting helpers to libclinic
Move some constants to libclinic (and annotate them as Final)

Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-113317: Clean up Argument Clinic global namespace

6dc7246

Split up clinic.py by establishing libclinic as a support package for
Argument Clinic. Get rid of clinic.py globals by either making them
class members, or by putting them into libclinic.

- Move INCLUDE_COMMENT_COLUMN to BlockPrinter
- Move NO_VARARG to CLanguage
- Move formatting helpers to libclinic
- Move some constants to libclinic (and annotate them as Final)

erlend-aasland requested a review from AlexWaygood as a code owner

December 22, 2023 22:47

erlend-aasland added the skip news label

Dec 22, 2023

bedevere-app Bot added the awaiting core review label

Dec 22, 2023

bedevere-app Bot mentioned this pull request

Dec 22, 2023

Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

Closed

erlend-aasland added 8 commits

December 22, 2023 23:50


          Address Alex's initial review comments

9e5ee9f


          Fix indent

c94618b


          Fix more indents

e5168ff


          Oh well, since we're introducing a new file, let's just run black on it

fe04157


          Also blacken __init__.py

a0c2ce5


          Comments

87e5514


          Nits

11cada6


          Nits

2bd7ea4

erlend-aasland commented

Dec 22, 2023

View reviewed changes

Comment thread

Tools/clinic/libclinic/formatting.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood approved these changes

Dec 23, 2023

View reviewed changes

AlexWaygood left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, and two nits; otherwise, this looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/clinic/libclinic/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/clinic/libclinic/formatting.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Dec 23, 2023


          Address review

6a2b9e4

erlend-aasland enabled auto-merge (squash)

December 23, 2023 00:20

erlend-aasland commented Dec 23, 2023

Copy link

Copy Markdown

Contributor Author

Thanks for the review! I have some more in the pipeline; I might create a follow-up PR tomorrow.

AlexWaygood reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland merged commit c3f92f6 into python:main

Dec 23, 2023

erlend-aasland deleted the clinic/globals branch

December 23, 2023 00:37

bedevere-app Bot removed the awaiting merge label

Dec 23, 2023

ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request

Dec 26, 2023


          pythongh-113317: Clean up Argument Clinic global namespace (python#11…

d05281a

…3414)

Split up clinic.py by establishing libclinic as a support package for
Argument Clinic. Get rid of clinic.py globals by either making them
class members, or by putting them into libclinic.

- Move INCLUDE_COMMENT_COLUMN to BlockPrinter
- Move NO_VARARG to CLanguage
- Move formatting helpers to libclinic
- Move some constants to libclinic (and annotate them as Final)

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request

Jan 22, 2024


          pythongh-113317: Clean up Argument Clinic global namespace (python#11…

17c9d92

…3414)

Split up clinic.py by establishing libclinic as a support package for
Argument Clinic. Get rid of clinic.py globals by either making them
class members, or by putting them into libclinic.

- Move INCLUDE_COMMENT_COLUMN to BlockPrinter
- Move NO_VARARG to CLanguage
- Move formatting helpers to libclinic
- Move some constants to libclinic (and annotate them as Final)

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-113317: Clean up Argument Clinic global namespace (python#11…

527be4d

…3414)

Split up clinic.py by establishing libclinic as a support package for
Argument Clinic. Get rid of clinic.py globals by either making them
class members, or by putting them into libclinic.

- Move INCLUDE_COMMENT_COLUMN to BlockPrinter
- Move NO_VARARG to CLanguage
- Move formatting helpers to libclinic
- Move some constants to libclinic (and annotate them as Final)

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-113317: Clean up Argument Clinic global namespace (python#11…

5b0a168

…3414)

Split up clinic.py by establishing libclinic as a support package for
Argument Clinic. Get rid of clinic.py globals by either making them
class members, or by putting them into libclinic.

- Move INCLUDE_COMMENT_COLUMN to BlockPrinter
- Move NO_VARARG to CLanguage
- Move formatting helpers to libclinic
- Move some constants to libclinic (and annotate them as Final)

Reviewers

AlexWaygood

AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Dec 22, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Dec 23, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

erlend-aasland commented Dec 22, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.