GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-110109: pathlib ABCs: drop use of `io.text_encoding()` by barneygale · Pull Request #113417 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Dec 22, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Do not use the locale-specific default encoding in PathBase.read_text() and write_text(). Locale settings shouldn't influence the operation of these base classes, which are intended mostly for implementing rich paths on nonlocal filesystems.

Also add a comment explaining the necessity of the io.text_encoding() call in Path.read_text() and write_text() despite its presence in open().

  • Issue: User-defined virtual path objects #110109

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-110109: pathlib ABCs: drop use of io.text_encoding()
b3a7c27 
Do not use the locale-specific default encoding in `PathBase.read_text()`
and `write_text()`. Locale settings shouldn't influence the operation of
these base classes, which are intended mostly for implementing rich paths
on *nonlocal* filesystems.
@barneygale barneygale added skip news topic-pathlib labels Dec 22, 2023
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 22, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 22, 2023
User-defined virtual path objects #110109
Closed
8 tasks done
@barneygale

barneygale commented Dec 23, 2023

Copy link
Copy Markdown
Contributor Author

Downstream pathlib_abc issue: barneygale/pathlib-abc#12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka requested a review from methane December 23, 2023 10:49
@barneygale
Merge branch 'main' into pathlib-abc-io-redux
16649ba
methane
methane approved these changes Dec 25, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 25, 2023
@barneygale

barneygale commented Dec 27, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the review, @methane
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale merged commit f8b6e17 into python:main Dec 27, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 27, 2023
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@barneygale @kulikjak
pythonGH-110109: pathlib ABCs: drop use of io.text_encoding() (pyth…
de5e342 
…on#113417)

Do not use the locale-specific default encoding in `PathBase.read_text()`
and `write_text()`. Locale settings shouldn't influence the operation of
these base classes, which are intended mostly for implementing rich paths
on *nonlocal* filesystems.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@barneygale @aisk
pythonGH-110109: pathlib ABCs: drop use of io.text_encoding() (pyth…
b08ec58 
…on#113417)

Do not use the locale-specific default encoding in `PathBase.read_text()`
and `write_text()`. Locale settings shouldn't influence the operation of
these base classes, which are intended mostly for implementing rich paths
on *nonlocal* filesystems.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@barneygale @Glyphack
pythonGH-110109: pathlib ABCs: drop use of io.text_encoding() (pyth…
20dffcf 
…on#113417)

Do not use the locale-specific default encoding in `PathBase.read_text()`
and `write_text()`. Locale settings shouldn't influence the operation of
these base classes, which are intended mostly for implementing rich paths
on *nonlocal* filesystems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@barneygale @methane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.