GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103092: Make `_elementtree` module importable in sub-interpreters by Eclips4 · Pull Request #113434 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Dec 23, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It's looks like _elementtree is already isolated: #104561 but field Py_mod_multiple_interpreters is still set to Py_MOD_MULTIPLE_INTERPRETERS_NOT_SUPPORTED, Kumar just forgot to change it :)

  • Issue: Isolate Stdlib Extension Modules #103092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
Enable imports of _elementtree module in sub-interpreters
74497e9
@Eclips4 Eclips4 added the skip news label Dec 23, 2023
@Eclips4
Eclips4 requested a review from ericsnowcurrently December 23, 2023 13:38
@bedevere-app bedevere-app Bot added the awaiting review label Dec 23, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 23, 2023
Isolate Stdlib Extension Modules #103092
Closed
24 of 25 tasks
@Eclips4
Eclips4 requested review from erlend-aasland and kumaraditya303 December 23, 2023 13:38
erlend-aasland
erlend-aasland approved these changes Dec 27, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 27, 2023
@erlend-aasland

erlend-aasland commented Dec 27, 2023

Copy link
Copy Markdown
Contributor

cc. @kumaraditya303 before landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Dec 28, 2023
View reviewed changes
@kumaraditya303

kumaraditya303 commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

Merging something after so long! Thanks
ericsnowcurrently reacted with heart emoji Eclips4 and ericsnowcurrently reacted with rocket emoji
All reactions
  • ❤️ 1 reaction
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 merged commit f167686 into python:main Dec 28, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 28, 2023
@Eclips4
Eclips4 deleted the issue-103092 branch December 28, 2023 13:21
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@Eclips4 @kulikjak
pythongh-103092: Make _elementtree module importable in sub-interpr…
18bb3df 
…eters (python#113434)

Enable imports of _elementtree module in sub-interpreters
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Eclips4 @aisk
pythongh-103092: Make _elementtree module importable in sub-interpr…
511f9d8 
…eters (python#113434)

Enable imports of _elementtree module in sub-interpreters
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Eclips4 @Glyphack
pythongh-103092: Make _elementtree module importable in sub-interpr…
89867ca 
…eters (python#113434)

Enable imports of _elementtree module in sub-interpreters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Eclips4 @erlend-aasland @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.