GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113317: Move more formatting helpers into libclinic by erlend-aasland · Pull Request #113438 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 23, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Move strip_leading_and_trailing_blank_lines() and make it internal to libclinic
  • Move normalize_snippet() to libclinic
  • Move format_escape() to libclinic
  • Move wrap_declarations() to libclinic
  • Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-113317: Move more formatting helpers into libclinic
e03e575 
- Move strip_leading_and_trailing_blank_lines() and make it internal to libclinic
- Move normalize_snippet() to libclinic
- Move format_escape() to libclinic
- Move wrap_declarations() to libclinic
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner December 23, 2023 16:39
@erlend-aasland erlend-aasland added the skip news label Dec 23, 2023
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 23, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 23, 2023
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
Closed
@erlend-aasland
Blacken
25c4ba0
AlexWaygood
AlexWaygood approved these changes Dec 23, 2023
View reviewed changes
Comment thread Tools/clinic/libclinic/formatting.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 23, 2023
@erlend-aasland @AlexWaygood
Update Tools/clinic/libclinic/formatting.py
19b9506 
Co-authored-by: Alex Waygood <[email protected]>
@erlend-aasland
erlend-aasland enabled auto-merge (squash) December 23, 2023 16:51
@erlend-aasland
erlend-aasland merged commit ca71987 into python:main Dec 23, 2023
@erlend-aasland
erlend-aasland deleted the clinic/globals-formatting branch December 23, 2023 17:08
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 23, 2023
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@erlend-aasland @ryan-duve
pythongh-113317: Move more formatting helpers into libclinic (python#…
7796995 
…113438)

Move the following global helpers into libclinic:
- format_escape()
- normalize_snippet()
- wrap_declarations()

Also move strip_leading_and_trailing_blank_lines() and make it internal to libclinic.
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@erlend-aasland @kulikjak
pythongh-113317: Move more formatting helpers into libclinic (python#…
995700d 
…113438)

Move the following global helpers into libclinic:
- format_escape()
- normalize_snippet()
- wrap_declarations()

Also move strip_leading_and_trailing_blank_lines() and make it internal to libclinic.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@erlend-aasland @aisk
pythongh-113317: Move more formatting helpers into libclinic (python#…
9f7f224 
…113438)

Move the following global helpers into libclinic:
- format_escape()
- normalize_snippet()
- wrap_declarations()

Also move strip_leading_and_trailing_blank_lines() and make it internal to libclinic.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@erlend-aasland @Glyphack
pythongh-113317: Move more formatting helpers into libclinic (python#…
1577fac 
…113438)

Move the following global helpers into libclinic:
- format_escape()
- normalize_snippet()
- wrap_declarations()

Also move strip_leading_and_trailing_blank_lines() and make it internal to libclinic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.