GeezerVison

All commit authors signed the Contributor License Agreement.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@jcomeauictx are you going to continue working on this PR?

@jcomeauictx are you going to continue working on this PR?

I've forgotten what else needs to be done. And in any case, nobody else seems interested in it.

I've forgotten what else needs to be done. And in any case, nobody else seems interested in it.

I'm interested :)
I think if you add tests you can ping someone from core members

OK, I'll look into it tomorrow. No idea where to add them, though, or what precisely needs to be tested.

Sorry I can't. I mean move on to the rest options

This PR is stale because it has been open for 30 days with no activity.

I've resolved the merge conflict and pushed some minor docs things.

default_content_type is defined on BaseHTTPRequestHandler, but only used in its subclass SimpleHTTPRequestHandler, in guess_type().

Should default_content_type be moved to SimpleHTTPRequestHandler?

Also, test() defaults HandlerClass=BaseHTTPRequestHandler, but the CLI calls it with HandlerClass=SimpleHTTPRequestHandler.

test() then sets HandlerClass.default_content_type. This doesn't matter to BaseHTTPRequestHandler if we move it, although we could also change test() to only use SimpleHTTPRequestHandler?

I think I had a reason to put it in BaseRequestHandler, but it's been a long time and I've moved on to other things. Do what seems best.

Documentation build overview

📚 cpython-previews | 🛠️ Build #32468450 | 📁 Comparing 4388da5 against main (69e0a78)

  🔍 Preview build  

Thanks!