GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update copyright years to 2024. by 0xSalikh · Pull Request #113608 · python/cpython

Conversation

@0xSalikh

@0xSalikh 0xSalikh commented Jan 1, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

📚 Documentation preview 📚: https://cpython-previews--113608.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@0xSalikh
Update year
dd1fb99
@0xSalikh
0xSalikh requested review from a team and vsajip as code owners January 1, 2024 01:20
@ghost

ghost commented Jan 1, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app

bedevere-app Bot commented Jan 1, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added the awaiting review label Jan 1, 2024
@Eclips4
Eclips4 requested review from benjaminp and removed request for a team and vsajip January 1, 2024 08:08
benjaminp
benjaminp previously requested changes Jan 4, 2024
View reviewed changes

@benjaminp benjaminp left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only touch files similar to previous iterations of this change (like 11f9932). We shouldn't be modifying the license headers of files from third party sources.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Include/internal/mimalloc/mimalloc.h Outdated
@@ -1,5 +1,5 @@
/* ----------------------------------------------------------------------------
Copyright (c) 2018-2023, Microsoft Research, Daan Leijen
Copyright (c) 2018-2024, Microsoft Research, Daan Leijen

@benjaminp benjaminp Jan 4, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These minmalloc files should not be touched.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@0xSalikh 0xSalikh Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Thank you for your comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Jan 4, 2024
@bedevere-app

bedevere-app Bot commented Jan 4, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@0xSalikh
Update mimalloc.h
7269e06
@bedevere-app

bedevere-app Bot commented Jan 5, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily

ned-deily commented Jan 15, 2024

Copy link
Copy Markdown
Member

One way or another, we should ensure that the copyright years are updated before the next release, which will likely be a 3.13 alpha in a few days.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily ned-deily added the release-blocker label Jan 15, 2024
hugovk added 2 commits January 15, 2024 18:24
@hugovk
Do not change third-party copyrights
c0366b9
@hugovk
Add 2024 to copyright
f62a744
@bedevere-app

bedevere-app Bot commented Jan 15, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk added skip issue skip news labels Jan 15, 2024
@hugovk

hugovk commented Jan 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've updated this PR to remove the year changes to third-party copyrights, and to add 2024 to the PSF's copyright in LICENSE.

CLA: @0xSalikh please could you click the button at #113608 (comment) to sign the CLA?

Even if they don't sign the CLA, I think this is trivial enough to merge without it (but it would be easier if it was).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
hugovk requested a review from benjaminp January 15, 2024 16:32
ned-deily
ned-deily approved these changes Jan 16, 2024
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting changes labels Jan 16, 2024
@ned-deily
ned-deily dismissed benjaminp’s stale review January 16, 2024 19:51

Looks like all the review comments have been resolved in @hugovk's commits.

@ambv ambv mentioned this pull request Jan 16, 2024
gh-101705: Use a range of years for copyright in LICENSE #101706
Closed
@hugovk
Use year range
9d2f2dd
@hugovk

hugovk commented Jan 16, 2024

Copy link
Copy Markdown
Member

Updated to use 2001-2024 year range in LICENSE as suggested in #101706: 9d2f2dd

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily
ned-deily approved these changes Jan 16, 2024
View reviewed changes
@ambv
ambv merged commit c86571e into python:main Jan 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 16, 2024
@gpshead

gpshead commented Jan 16, 2024

Copy link
Copy Markdown
Member

IMNSHO We should stop doing this.

Trusted Non-PSF legal advice I've received in the past has been that nobody should bother to change dates in a Copyright (C) statement.

Unless the PSF's current legal council specifically advises us to do this, lets stop updating these dates in the future. (If they agree that we should not, I'd also ask them if we could get rid of the confusing "-XXXX" through style date at the same time to avoid people wrongly thinking they're out of date and re-proposing the same change in the future)

hugovk and pombredanne reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@0xSalikh @hugovk @kulikjak
Update copyright years to 2024. (pythonGH-113608)
6f64383
Co-authored-by: Hugo van Kemenade <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@0xSalikh @hugovk @aisk
Update copyright years to 2024. (pythonGH-113608)
308d822
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk mentioned this pull request Mar 15, 2024
Use a range of years for copyright in LICENSE #101705
Closed
@pombredanne

pombredanne commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

IMNSHO We should stop doing this.

Trusted Non-PSF legal advice I've received in the past has been that nobody should bother to change dates in a Copyright (C) statement.

Unless the PSF's current legal council specifically advises us to do this, lets stop updating these dates in the future. (If they agree that we should not, I'd also ask them if we could get rid of the confusing "-XXXX" through style date at the same time to avoid people wrongly thinking they're out of date and re-proposing the same change in the future)

@gpshead I agree ++. Updating these dates is mostly harmless, and eventually useless busywork with neither legal nor value. I am talking from experience, as I have some software legal and license compliance chops.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@0xSalikh @hugovk @Glyphack
Update copyright years to 2024. (pythonGH-113608)
22d7745
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk mentioned this pull request Oct 29, 2024
Use static copyright years #126133
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes
@benjaminp benjaminp Awaiting requested review from benjaminp

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release-blocker skip issue skip news

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@0xSalikh @ned-deily @hugovk @gpshead @pombredanne @benjaminp @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.