GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||
GeezerVison is showing github.com — Update copyright years to 2024. by 0xSalikh · Pull Request #113608 · python/cpython Conversation
| ||||||||||||||||||||||
|
The following commit authors need to sign the Contributor License Agreement: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please only touch files similar to previous iterations of this change (like 11f9932). We shouldn't be modifying the license headers of files from third party sources.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| @@ -1,5 +1,5 @@ | |||
| /* ---------------------------------------------------------------------------- | |||
| Copyright (c) 2018-2023, Microsoft Research, Daan Leijen | |||
| Copyright (c) 2018-2024, Microsoft Research, Daan Leijen | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
These minmalloc files should not be touched.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Corrected. Thank you for your comment)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
One way or another, we should ensure that the copyright years are updated before the next release, which will likely be a 3.13 alpha in a few days. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I've updated this PR to remove the year changes to third-party copyrights, and to add 2024 to the PSF's copyright in CLA: @0xSalikh please could you click the button at #113608 (comment) to sign the CLA? Even if they don't sign the CLA, I think this is trivial enough to merge without it (but it would be easier if it was). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Looks like all the review comments have been resolved in @hugovk's commits.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
IMNSHO We should stop doing this. Trusted Non-PSF legal advice I've received in the past has been that nobody should bother to change dates in a Copyright (C) statement. Unless the PSF's current legal council specifically advises us to do this, lets stop updating these dates in the future. (If they agree that we should not, I'd also ask them if we could get rid of the confusing "-XXXX" through style date at the same time to avoid people wrongly thinking they're out of date and re-proposing the same change in the future) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@gpshead I agree ++. Updating these dates is mostly harmless, and eventually useless busywork with neither legal nor value. I am talking from experience, as I have some software legal and license compliance chops. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.