GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110721: Remove unused code from suggestions.c after moving PyErr_Display to use the traceback module by pablogsal · Pull Request #113712 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jan 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Use the traceback module for PyErr_Display() and fallback to the C implementation #110721

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested review from a team and iritkatriel as code owners January 4, 2024 19:46
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 4, 2024
Use the traceback module for PyErr_Display() and fallback to the C implementation #110721
Closed
@pablogsal
pablogsal force-pushed the gh-110721-2 branch from 8eb16ea to d85a8ea Compare January 4, 2024 19:47
@pablogsal
pythongh-110721: Remove unused code from suggestions.c after moving P…
d7bd894 
…yErr_Display to use the traceback module

Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal force-pushed the gh-110721-2 branch from d85a8ea to d7bd894 Compare January 4, 2024 20:00
@pablogsal pablogsal added the skip news label Jan 4, 2024
@pablogsal
Update Python/stdlib_module_names.h
6e1fb7d
@pablogsal
pablogsal merged commit a03ec20 into python:main Jan 8, 2024
@pablogsal
pablogsal deleted the gh-110721-2 branch January 8, 2024 15:10
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 8, 2024
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@pablogsal @kulikjak
pythongh-110721: Remove unused code from suggestions.c after moving P…
91c30f1 
…yErr_Display to use the traceback module (python#113712)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@pablogsal @aisk
pythongh-110721: Remove unused code from suggestions.c after moving P…
03f35d8 
…yErr_Display to use the traceback module (python#113712)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pablogsal @Glyphack
pythongh-110721: Remove unused code from suggestions.c after moving P…
62c7f00 
…yErr_Display to use the traceback module (python#113712)
@IvyXu420 IvyXu420 mentioned this pull request Jul 25, 2026
gh-110721: Remove undefined _Py_Offer_Suggestions in pycore_pyerrors.h #154664
Merged
@moontc moontc mentioned this pull request Nov 8, 2026
pure-Python suggestion fallback differs from the C implementation #161495
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.