GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113732: Fix support of QUOTE_NOTNULL and QUOTE_STRINGS in csv.reader by serhiy-storchaka · Pull Request #113738 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 5, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: CSV reader should support QUOTE_NOTNULL and QUOTE_STRINGS #113732

📚 Documentation preview 📚: https://cpython-previews--113738.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-113732: Fix support of QUOTE_NOTNULL and QUOTE_STRINGS in cs…
7e1fe69 
…v.reader
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.12 only security fixes labels Jan 5, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 5, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 5, 2024
CSV reader should support QUOTE_NOTNULL and QUOTE_STRINGS #113732
Closed
merwok
merwok reviewed Jan 5, 2024
View reviewed changes
Comment thread Modules/_csv.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Jan 5, 2024
View reviewed changes
Comment thread Modules/_csv.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_csv.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_csv.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka commented Jan 5, 2024
View reviewed changes
Comment thread Modules/_csv.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka and others added 2 commits January 5, 2024 19:41
@serhiy-storchaka @erlend-aasland
Apply suggestions from code review
c0d6557 
Co-authored-by: Erlend E. Aasland <[email protected]>
@serhiy-storchaka
Use bool.
11768e5
erlend-aasland
erlend-aasland approved these changes Jan 5, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 5, 2024
@serhiy-storchaka
serhiy-storchaka requested a review from Yhg1s January 8, 2024 10:39
serhiy-storchaka added 2 commits January 22, 2024 15:37
@serhiy-storchaka
Merge branch 'main' into csv-reader-unquoted
be32308
@serhiy-storchaka
Test QUOTE_NOTNULL with skipinitialspace.
0dab238
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.12 only security fixes label Jan 22, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) January 22, 2024 13:56
merwok
merwok reviewed Jan 22, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed Jan 22, 2024
View reviewed changes
Comment thread Modules/_csv.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@merwok
merwok disabled auto-merge January 22, 2024 15:40
@serhiy-storchaka @merwok
Apply suggestions from code review
31aaff5 
Co-authored-by: Éric <[email protected]>
@serhiy-storchaka
serhiy-storchaka merged commit ea30a28 into python:main Jan 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 30, 2024
@serhiy-storchaka
serhiy-storchaka deleted the csv-reader-unquoted branch January 30, 2024 12:21
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-113732: Fix support of QUOTE_NOTNULL and QUOTE_STRINGS in cs…
f77074d 
…v.reader (pythonGH-113738)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @merwok @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.