GeezerVison

Can you describe here how are you testing that the integration works?

@ambv Do you want to catch up to see if we can add a dtrace Buildbot? I think we can use the perf Buildbot to track this

This change looks correct to me. I haven't tested though.

I merged this because it looks correct. We really should get buildbot coverage for such a build though...

Thanks!

@pablogsal sure - I maintain an internal Solaris Python buildbot that does daily builds with our patches applied as well. After the weekend, I noticed builds were failing, found the issue (I already fixed a similar one some time ago via #11194), added the patch, and rebuilt the latest bits without issues.

As for the buildbot coverage, AFAIK, only some platforms need to touch the object files with dtrace, which might be the reason this wasn't found with e.g. Linux buildbots?

BTW, there is a Solaris SPARC worker in the Python buildbot (e.g. https://buildbot.python.org/all/#/builders/742), but it's not in the best state because it never passes the tests. I have several PRs open that should make it green (patches we apply internally); once those get in, it should be much more usable.