GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — gh-103092: Ensure `_ctypes.c` static types are accessed via global state by neonene · Pull Request #113857 · python/cpython Conversation
|
|
@erlend-aasland, do you want to review these two PRs? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sure, I'll get to it later today. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Done. I'll update this after #113620 is merged. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
_ctypes.c static types are accessed via global state_ctypes.c static types are accessed via global state
_ctypes.c static types are accessed via global state_ctypes.c static types are accessed via global state
|
I think this is ready for review. Sorry for mistakenly wiping out old commits (from web). Actual diff with a1ade06: Details--- Modules/_ctypes/_ctypes.c +++ Modules/_ctypes/_ctypes.c @@ -128,13 +128,6 @@ -static PyTypeObject UnionType_Type; static PyTypeObject Union_Type; static PyTypeObject Struct_Type; static PyTypeObject Simple_Type; ctypes_state global_state = { .PyCStgDict_Type = &PyCStgDict_Type, - .PyCStructType_Type = &PyCStructType_Type, - .UnionType_Type = &UnionType_Type, - .PyCPointerType_Type = &PyCPointerType_Type, - .PyCArrayType_Type = &PyCArrayType_Type, - .PyCSimpleType_Type = &PyCSimpleType_Type, - .PyCFuncPtrType_Type = &PyCFuncPtrType_Type, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks, Victor! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I merged this change which is a good start for futher work. I closed my similar duplicated (less complete) PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.