GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-87868: Sort and remove duplicates in getenvironment() (GH-102731) by miss-islington · Pull Request #113865 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit c31be58)

Co-authored-by: AN Long [email protected]
Co-authored-by: Alex Waygood [email protected]
Co-authored-by: Pieter Eendebak [email protected]
Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: [_winapi] correctly sort and remove duplicates in getenvironment() #87868

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aisk @AlexWaygood
@eendebakpt @erlend-aasland @miss-islington
pythongh-87868: Sort and remove duplicates in getenvironment() (pytho…
12db2cd 
…nGH-102731)

(cherry picked from commit c31be58)

Co-authored-by: AN Long <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Pieter Eendebak <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@miss-islington
miss-islington requested a review from gpshead as a code owner January 9, 2024 15:59
@bedevere-app bedevere-app Bot added the awaiting review label Jan 9, 2024
This was referenced Jan 9, 2024
gh-87868: Sort and remove duplicates in getenvironment() #102731
Merged
[_winapi] correctly sort and remove duplicates in getenvironment() #87868
Closed
@zooba
zooba enabled auto-merge (squash) January 9, 2024 16:00
@gpshead gpshead self-assigned this Jan 10, 2024
@aisk @zooba @gpshead
pythongh-87868: Skip test_one_environment_variable in `test_subproc…
84a5a59 
…ess` when the platform or build cannot do that (python#113867)

* improve the assert for test_one_environment_variable
* skip some test in test_subprocess when python is configured with shared
* also skip the test if AddressSanitizer is enabled

---------

Co-authored-by: Steve Dower <[email protected]>
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 10, 2024
@bedevere-bot

bedevere-bot commented Jan 10, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 84a5a59 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 10, 2024
@zooba
zooba merged commit 4050a15 into python:3.12 Jan 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 10, 2024
@miss-islington
miss-islington deleted the backport-c31be58-3.12 branch January 2, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @bedevere-bot @gpshead @zooba @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.