GeezerVison

CI looks good (and Azure Pipelines can be ignored here), so congrats! It's in!

GH-113865 is a backport of this pull request to the 3.12 branch.

GH-113866 is a backport of this pull request to the 3.11 branch.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 3.x has failed when building commit c31be58.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/15/builds/6594) and take a look at the build logs.
4. Check if the failure is related to this commit (c31be58) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/15/builds/6594

Failed tests:

• test_subprocess

Failed subtests:

• test_one_environment_variable - test.test_subprocess.ProcessTestCase.test_one_environment_variable
• test_one_environment_variable - test.test_subprocess.ProcessTestCaseNoPoll.test_one_environment_variable

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_subprocess.py", line 847, in test_one_environment_variable
    self.assertTrue(stdout.startswith(b"fruit=orange"))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 3.x has failed when building commit c31be58.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/185/builds/5849) and take a look at the build logs.
4. Check if the failure is related to this commit (c31be58) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/185/builds/5849

Failed tests:

• test_subprocess

Failed subtests:

• test_one_environment_variable - test.test_subprocess.ProcessTestCase.test_one_environment_variable
• test_one_environment_variable - test.test_subprocess.ProcessTestCaseNoPoll.test_one_environment_variable

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/test/test_subprocess.py", line 847, in test_one_environment_variable
    self.assertTrue(stdout.startswith(b"fruit=orange"))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 3.x has failed when building commit c31be58.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/529/builds/5692) and take a look at the build logs.
4. Check if the failure is related to this commit (c31be58) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/529/builds/5692

Failed tests:

• test_subprocess

Failed subtests:

• test_one_environment_variable - test.test_subprocess.ProcessTestCase.test_one_environment_variable
• test_one_environment_variable - test.test_subprocess.ProcessTestCaseNoPoll.test_one_environment_variable

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64/build/Lib/test/test_subprocess.py", line 847, in test_one_environment_variable
    self.assertTrue(stdout.startswith(b"fruit=orange"))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true

Okay, these buildbot failures look related to the new test. Will be a couple hours before I can dig into it myself, so if someone else gets started first, I'd add the actual stdout to the message parameter of the assertTrue call to see what's happening there.

It's possible that the process is failing to start with a mostly empty environment?

I'm attempting to address it, I think maybe it's caused by create a new process need some basic environment to start with.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable 3.x has failed when building commit c31be58.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/125/builds/5079) and take a look at the build logs.
4. Check if the failure is related to this commit (c31be58) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/125/builds/5079

Failed tests:

• test_subprocess

Failed subtests:

• test_one_environment_variable - test.test_subprocess.ProcessTestCase.test_one_environment_variable
• test_one_environment_variable - test.test_subprocess.ProcessTestCaseNoPoll.test_one_environment_variable

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_subprocess.py", line 847, in test_one_environment_variable
    self.assertTrue(stdout.startswith(b"fruit=orange"))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x has failed when building commit c31be58.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/469/builds/6966) and take a look at the build logs.
4. Check if the failure is related to this commit (c31be58) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/469/builds/6966

Failed tests:

• test_subprocess

Failed subtests:

• test_one_environment_variable - test.test_subprocess.ProcessTestCase.test_one_environment_variable
• test_one_environment_variable - test.test_subprocess.ProcessTestCaseNoPoll.test_one_environment_variable

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/test_subprocess.py", line 847, in test_one_environment_variable
    self.assertTrue(stdout.startswith(b"fruit=orange"))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit c31be58.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/506/builds/6791) and take a look at the build logs.
4. Check if the failure is related to this commit (c31be58) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/506/builds/6791

Failed tests:

• test_subprocess

Failed subtests:

• test_one_environment_variable - test.test_subprocess.ProcessTestCase.test_one_environment_variable
• test_one_environment_variable - test.test_subprocess.ProcessTestCaseNoPoll.test_one_environment_variable

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_subprocess.py", line 847, in test_one_environment_variable
    self.assertTrue(stdout.startswith(b"fruit=orange"))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true

Change the assertTrue to assertEqual will help to address it. Should I open a new PR to do this, or is there some other way to do it?

The change will be like #113867

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable 3.x has failed when building commit c31be58.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/543/builds/5159) and take a look at the build logs.
4. Check if the failure is related to this commit (c31be58) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/543/builds/5159

Failed tests:

• test_subprocess

Failed subtests:

• test_one_environment_variable - test.test_subprocess.ProcessTestCase.test_one_environment_variable
• test_one_environment_variable - test.test_subprocess.ProcessTestCaseNoPoll.test_one_environment_variable

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/test_subprocess.py", line 847, in test_one_environment_variable
    self.assertTrue(stdout.startswith(b"fruit=orange"))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true