GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109862: Fix test_create_subprocess_with_pidfd when it was run separately by serhiy-storchaka · Pull Request #113991 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test_create_subprocess_with_pidfd in test_asyncio.test_subprocess is not independent #109862

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-109862: Fix test_create_subprocess_with_pidfd when it was ru…
43817bc 
…n separately
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes labels Jan 12, 2024
@serhiy-storchaka
serhiy-storchaka requested a review from gvanrossum January 12, 2024 15:35
@serhiy-storchaka
serhiy-storchaka requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners January 12, 2024 15:35
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 12, 2024
test_create_subprocess_with_pidfd in test_asyncio.test_subprocess is not independent #109862
Closed
gpshead
gpshead approved these changes Jan 12, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 12, 2024
gvanrossum
gvanrossum approved these changes Jan 14, 2024
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Painful corner case. :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka merged commit f8a7910 into python:main Jan 15, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 15, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 15, 2024
@serhiy-storchaka
serhiy-storchaka deleted the test_create_subprocess_with_pidfd branch January 15, 2024 07:26
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2024
@serhiy-storchaka @miss-islington
pythongh-109862: Fix test_create_subprocess_with_pidfd when it was ru…
ca0b485 
…n separately (pythonGH-113991)

(cherry picked from commit f8a7910)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 15, 2024

Copy link
Copy Markdown

GH-114072 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 15, 2024
serhiy-storchaka added a commit that referenced this pull request Jan 15, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-109862: Fix test_create_subprocess_with_pidfd when it was r…
41a94c9 
…un separately (GH-113991) (GH-114072)

(cherry picked from commit f8a7910)

Co-authored-by: Serhiy Storchaka <[email protected]>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@serhiy-storchaka @kulikjak
pythongh-109862: Fix test_create_subprocess_with_pidfd when it was ru…
1e0e9a3 
…n separately (pythonGH-113991)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-109862: Fix test_create_subprocess_with_pidfd when it was ru…
49db90b 
…n separately (pythonGH-113991)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-109862: Fix test_create_subprocess_with_pidfd when it was ru…
f1abb1c 
…n separately (pythonGH-113991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @gpshead @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.