GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-95649: Document that asyncio contains uvloop code (GH-107536) by aloisklink · Pull Request #114046 · python/cpython

Conversation

@aloisklink

@aloisklink aloisklink commented Jan 14, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Some of the asyncio SSL changes in GH-31275 (see 1) were taken from v0.16.0 of the uvloop project (see 2). In order to comply with the MIT license, we need to just need to document the copyright information.

(cherry picked from commit dce30c9)

Backport was due to a merge conflict in Doc/license.rst due to:

  • f66be6b removing a license in Doc/license.rst
  • 05f2f0a adding a license in Doc/license.rst
  • Issue: New asyncio ssl implementation is lacking license and origin information #95649

📚 Documentation preview 📚: https://cpython-previews--114046.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aloisklink
[3.12] pythongh-95649: Document that asyncio contains uvloop code (py…
253e92b 
…thonGH-107536)

Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: python#31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0

(cherry picked from commit dce30c9)
@aloisklink
aloisklink requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners January 14, 2024 00:18
@bedevere-app bedevere-app Bot added the awaiting review label Jan 14, 2024
This was referenced Jan 14, 2024
gh-95649: Document that asyncio contains uvloop code #107536
Merged
New asyncio ssl implementation is lacking license and origin information #95649
Closed
@AA-Turner
AA-Turner merged commit fa7d8e9 into python:3.12 Jan 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@aloisklink @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.