GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44011: New asyncio ssl implementation by kumaraditya303 · Pull Request #31275 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Feb 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Co-Authored-By: Andrew Svetlov [email protected]

https://bugs.python.org/issue44011

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
kumaraditya303 and others added 3 commits February 11, 2022 12:17
@kumaraditya303 @asvetlov
bpo-44011: New asyncio ssl implementation
572ca54
Co-Authored-By: Andrew Svetlov <[email protected]>
@kumaraditya303
fix warning
aec4463
@kumaraditya303
fix typo
10db2f2
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 11, 2022
@bedevere-bot bedevere-bot added the awaiting review label Feb 11, 2022
@kumaraditya303

kumaraditya303 commented Feb 11, 2022

Copy link
Copy Markdown
Contributor Author

@sobolevn Test with buildbots. Thanks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 11, 2022
@bedevere-bot

bedevere-bot commented Feb 11, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 10db2f2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 11, 2022
@asvetlov

asvetlov commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

Thanks for picking this work up!

kumaraditya303 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303
kumaraditya303 marked this pull request as ready for review February 11, 2022 14:54
@kumaraditya303
kumaraditya303 requested review from 1st1 and asvetlov as code owners February 11, 2022 14:54
@kumaraditya303

kumaraditya303 commented Feb 11, 2022

Copy link
Copy Markdown
Contributor Author

cc @asvetlov The build-bots passed and are all green, ready for merge!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@asvetlov asvetlov added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 13, 2022
@bedevere-bot

bedevere-bot commented Feb 13, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @asvetlov for commit 10db2f2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 13, 2022
asvetlov
asvetlov requested changes Feb 13, 2022
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I've scheduled yet another buildbots round to make sure.

Also, please document the new ssh_shutdown_timeout

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot removed the awaiting review label Feb 13, 2022
@bedevere-bot

bedevere-bot commented Feb 13, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting changes label Feb 13, 2022
@kumaraditya303

kumaraditya303 commented Feb 14, 2022

Copy link
Copy Markdown
Contributor Author

@asvetlov I am busy currently so I suggest to land this and I'll prepare a PR for docs shortly.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303
kumaraditya303 requested a review from asvetlov February 14, 2022 06:57
@sobolevn

sobolevn commented Feb 14, 2022

Copy link
Copy Markdown
Member

This failure looks related: https://buildbot.python.org/all/#/builders/178/builds/435

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@asvetlov

asvetlov commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

@sobolevn why do you think so?
I read the following summary as everything is almost fine, test_concurrent_futures alters the environment.
The concurrent futures are not affected by this PR, I read this error as unrelated.

1 test altered the execution environment:
    test_concurrent_futures
14 tests skipped:
    test_devpoll test_ioctl test_kqueue test_msilib test_nis
    test_readline test_startfile test_tix test_tk test_ttk_guionly
    test_winconsoleio test_winreg test_winsound test_zipfile64
1 re-run test:
    test_unittest
    ```
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303

kumaraditya303 commented Feb 14, 2022

Copy link
Copy Markdown
Contributor Author

It is clearly unrelated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asvetlov
asvetlov approved these changes Feb 15, 2022
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Feb 15, 2022
@asvetlov
asvetlov merged commit 13c10bf into python:main Feb 15, 2022
@bedevere-bot

bedevere-bot commented Feb 15, 2022

Copy link
Copy Markdown

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303
kumaraditya303 deleted the asyncio-ssl branch March 4, 2022 13:55
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Mar 10, 2022
@AlexWaygood
bpo-46198: Fix test_asyncio.test_sslproto
b9e02a7
pythonGH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, pythonGH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
@AlexWaygood AlexWaygood mentioned this pull request Mar 10, 2022
bpo-46198: Fix test_asyncio.test_sslproto #31801
Merged
JelleZijlstra pushed a commit that referenced this pull request Mar 10, 2022
@AlexWaygood
bpo-46198: Fix test_asyncio.test_sslproto (GH-31801)
4052dd2
GH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, GH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
@kumaraditya303 kumaraditya303 mentioned this pull request May 31, 2022
Asyncio StreamReader fails to close Transport #78357
Closed
@ambv ambv mentioned this pull request Aug 3, 2022
test_asyncio: test_create_server_ssl_over_ssl() failed on ARM64 macOS 3.x #95573
Closed
@tiran tiran mentioned this pull request Aug 4, 2022
New asyncio ssl implementation is lacking license and origin information #95649
Closed
ambv added a commit to ambv/cpython that referenced this pull request Aug 4, 2022
@ambv
Revert "bpo-44011: New asyncio ssl implementation (python#31275)"
07e6a8f
This reverts commit 13c10bf.
@ambv ambv mentioned this pull request Aug 4, 2022
[3.11] gh-88177: Revert the new asyncio.sslproto implementation #95663
Closed
This was referenced Sep 15, 2022
_SSLProtocolTransport.close() cannot close the connection until timeout or EOF MagicStack/uvloop#471
Open
(client) connections cannot be really closed before EOF with uvloop enabled aio-libs/aiohttp#6762
Closed
@skshetry skshetry mentioned this pull request Jan 5, 2023
_prepare_credentials: connector fix for fsspec>=2022.12 treeverse/dvc-http#28
Merged
aloisklink added a commit to aloisklink/cpython that referenced this pull request Aug 1, 2023
@aloisklink
Document that asyncio contains uvloop code
efa45b0
Some of the asyncio SSL changes in pythonGH-31275 were taken from
[v0.16.0 of the uvloop project][1]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: https://github.com/MagicStack/uvloop/tree/v0.16.0
@aloisklink aloisklink mentioned this pull request Aug 1, 2023
gh-95649: Document that asyncio contains uvloop code #107536
Merged
@bdraco bdraco mentioned this pull request Oct 31, 2023
Fix usage of proxy.py in test_proxy_functional aio-libs/aiohttp#7773
Merged
@mjpieters mjpieters mentioned this pull request Dec 16, 2023
asyncio.sslproto.SSLProtocol exception handling triggers TypeError: SSLProtocol._abort() takes 1 positional argument but 2 were given #113214
Closed
AA-Turner pushed a commit that referenced this pull request Jan 12, 2024
@aloisklink
gh-95649: Document that asyncio contains uvloop code (#107536)
dce30c9
Some of the asyncio SSL changes in GH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: #31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
aloisklink added a commit to aloisklink/cpython that referenced this pull request Jan 14, 2024
@aloisklink
[3.12] pythongh-95649: Document that asyncio contains uvloop code (py…
5fc1d7f
…thonGH-107536)

Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: python#31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
(cherry picked from commit dce30c9)

Co-authored-by: Alois Klink <[email protected]>
aloisklink added a commit to aloisklink/cpython that referenced this pull request Jan 14, 2024
@aloisklink
[3.12] pythongh-95649: Document that asyncio contains uvloop code (py…
253e92b
…thonGH-107536)

Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: python#31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0

(cherry picked from commit dce30c9)
This was referenced Jan 14, 2024
[3.11] gh-95649: Document that asyncio contains uvloop code (GH-107536) #114045
Merged
[3.12] gh-95649: Document that asyncio contains uvloop code (GH-107536) #114046
Merged
AA-Turner pushed a commit that referenced this pull request Jan 14, 2024
@aloisklink
[3.11] gh-95649: Document that asyncio contains uvloop code (GH-107536)…
0d12a64
… (#114045)

Some of the asyncio SSL changes in GH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: #31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0

(cherry picked from commit dce30c9)
AA-Turner pushed a commit that referenced this pull request Jan 14, 2024
@aloisklink
[3.12] gh-95649: Document that asyncio contains uvloop code (GH-107536)…
fa7d8e9
… (#114046)

Some of the asyncio SSL changes in GH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: #31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0

(cherry picked from commit dce30c9)
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@aloisklink @kulikjak
pythongh-95649: Document that asyncio contains uvloop code (python#10…
8e55b87
…7536)

Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: python#31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@aloisklink @aisk
pythongh-95649: Document that asyncio contains uvloop code (python#10…
f0bcb29
…7536)

Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: python#31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
jessecomeau87 pushed a commit to jessecomeau87/Python that referenced this pull request May 20, 2024
@aloisklink
[3.11] gh-95649: Document that asyncio contains uvloop code (GH-107536)
d5d1111
Some of the asyncio SSL changes in GH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: python/cpython#31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0

(cherry picked from commit dce30c9)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@aloisklink @Glyphack
pythongh-95649: Document that asyncio contains uvloop code (python#10…
d0d6e55
…7536)

Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from
v0.16.0 of the uvloop project [2]. In order to comply with the MIT
license, we need to just need to document the copyright information.

[1]: python#31275
[2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kumaraditya303 @bedevere-bot @asvetlov @sobolevn @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.