GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — bpo-44011: New asyncio ssl implementation by kumaraditya303 · Pull Request #31275 · python/cpython Conversation
|
|
@sobolevn Test with buildbots. Thanks |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 10db2f2 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for picking this work up! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
cc @asvetlov The build-bots passed and are all green, ready for merge! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @asvetlov for commit 10db2f2 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I've scheduled yet another buildbots round to make sure.
Also, please document the new ssh_shutdown_timeout
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@asvetlov I am busy currently so I suggest to land this and I'll prepare a PR for docs shortly. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This failure looks related: https://buildbot.python.org/all/#/builders/178/builds/435 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@sobolevn why do you think so? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It is clearly unrelated. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Ok, lgtm
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@asvetlov: Please replace |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
pythonGH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, pythonGH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
GH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, GH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
This reverts commit 13c10bf.
Some of the asyncio SSL changes in pythonGH-31275 were taken from [v0.16.0 of the uvloop project][1]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: https://github.com/MagicStack/uvloop/tree/v0.16.0
Some of the asyncio SSL changes in GH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: #31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
…thonGH-107536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9) Co-authored-by: Alois Klink <[email protected]>
…thonGH-107536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9)
… (#114045) Some of the asyncio SSL changes in GH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: #31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9)
… (#114046) Some of the asyncio SSL changes in GH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: #31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9)
…7536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
…7536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
Some of the asyncio SSL changes in GH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python/cpython#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9)
…7536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.