GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114050: Fix crash when more than two arguments are passed to int() by kcatss · Pull Request #114067 · python/cpython

Conversation

@kcatss

@kcatss kcatss commented Jan 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove the typo in the format string, as it is unnecessary

issue : #114050

  • Issue: crash in long_vectorcall in longobject.c #114050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kcatss
pythongh-114050: Remove typo format string in longobject
4bd6dc6
@ghost

ghost commented Jan 14, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jan 14, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Jan 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 14, 2024
crash in long_vectorcall in longobject.c #114050
Closed
skirpichev
skirpichev approved these changes Jan 15, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jan 15, 2024
@AA-Turner

AA-Turner commented Jan 15, 2024

Copy link
Copy Markdown
Member

Can you add a test and a blurb entry?

A
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja
hauntsaninja reviewed Jan 15, 2024
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the find! :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
serhiy-storchaka
serhiy-storchaka approved these changes Jan 15, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 15, 2024
@serhiy-storchaka

serhiy-storchaka commented Jan 15, 2024

Copy link
Copy Markdown
Member

A good place for test: in Lib/test/test_int.py, just after self.assertRaises(TypeError, int, 1, 12). But use valid first two args.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4
pythongh-114050: Add test case and NEWS entry
c644351
@Eclips4

Eclips4 commented Jan 17, 2024

Copy link
Copy Markdown
Member

To help this move forward I added a test case and NEWS entry.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4
Eclips4 requested a review from serhiy-storchaka January 17, 2024 21:52
skirpichev
skirpichev approved these changes Jan 18, 2024
View reviewed changes
@serhiy-storchaka serhiy-storchaka changed the title gh-114050: Remove typo format string in longobject gh-114050: Fix crash when more than two arguments are passed to int() Jan 18, 2024
@serhiy-storchaka
serhiy-storchaka merged commit a571a2f into python:main Jan 18, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 18, 2024
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@kcatss @Eclips4 @kulikjak
pythongh-114050: Fix crash when more than two arguments are passed to…
8f8613e 
… int() (pythonGH-114067)

Co-authored-by: Kirill Podoprigora <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@kcatss @Eclips4 @aisk
pythongh-114050: Fix crash when more than two arguments are passed to…
fd69fae 
… int() (pythonGH-114067)

Co-authored-by: Kirill Podoprigora <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@kcatss @Eclips4 @Glyphack
pythongh-114050: Fix crash when more than two arguments are passed to…
f2d4a09 
… int() (pythonGH-114067)

Co-authored-by: Kirill Podoprigora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments
@skirpichev skirpichev skirpichev approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kcatss @AA-Turner @serhiy-storchaka @Eclips4 @skirpichev @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.