GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114107: test.pythoninfo logs Windows Developer Mode by vstinner · Pull Request #114121 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also, don't skip the whole collect_windows() if ctypes is missing.

  • Issue: importlib.metadata test fails on Windows if symlinks aren't allowed #114107

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-114107: test.pythoninfo logs Windows Developer Mode
f44a442 
Also, don't skip the whole collect_windows() if ctypes is missing.
@vstinner vstinner added the skip news label Jan 16, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 16, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 16, 2024
importlib.metadata test fails on Windows if symlinks aren't allowed #114107
Closed
@vstinner vstinner mentioned this pull request Jan 16, 2024
We don't have a dedicated Windows bot with disabled symlinks python/buildmaster-config#454
Open
vstinner added 2 commits January 16, 2024 16:24
@vstinner
Fix test.pythoninfo on Linux
f2c2c02
@vstinner
log also ctypes.windll.shell32.IsUserAnAdmin()
c0ea117
@vstinner

vstinner commented Jan 16, 2024

Copy link
Copy Markdown
Member Author

Developer Mode Disabled

test.pythoninfo on a regular shell (cmd.exe):

support_os_helper.can_symlink: False
windows.developer_mode: disabled
windows.is_admin: 0

=> cannot create symlinks.

test.pythoninfo on a SSH shell:

support_os_helper.can_symlink: True
windows.developer_mode: disabled
windows.is_admin: 1

=> can create symlinks thanks to administrator rights.

Developer Mode Enabled

test.pythoninfo on a regular shell (cmd.exe):

support_os_helper.can_symlink: True
windows.developer_mode: enabled
windows.is_admin: 0

=> can create symlinks thanks to Developer Mode.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit c77f552 into python:main Jan 16, 2024
@vstinner
vstinner deleted the pythoninfo_devmode branch January 16, 2024 16:23
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 16, 2024
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 16, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 16, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jan 16, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2024
@vstinner @miss-islington
pythongh-114107: test.pythoninfo logs Windows Developer Mode (pythonG…
dcfa187 
…H-114121)

Also, don't skip the whole collect_windows() if ctypes is missing.

Log also ctypes.windll.shell32.IsUserAnAdmin().
(cherry picked from commit c77f552)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 16, 2024

Copy link
Copy Markdown

GH-114128 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2024
@vstinner @miss-islington
pythongh-114107: test.pythoninfo logs Windows Developer Mode (pythonG…
2af3cb9 
…H-114121)

Also, don't skip the whole collect_windows() if ctypes is missing.

Log also ctypes.windll.shell32.IsUserAnAdmin().
(cherry picked from commit c77f552)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 16, 2024
@bedevere-app

bedevere-app Bot commented Jan 16, 2024

Copy link
Copy Markdown

GH-114129 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 16, 2024
vstinner added a commit that referenced this pull request Jan 16, 2024
@miss-islington @vstinner
[3.11] gh-114107: test.pythoninfo logs Windows Developer Mode (GH-114121
ddc9e34 
) (#114128)

gh-114107: test.pythoninfo logs Windows Developer Mode (GH-114121)

Also, don't skip the whole collect_windows() if ctypes is missing.

Log also ctypes.windll.shell32.IsUserAnAdmin().
(cherry picked from commit c77f552)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Jan 16, 2024
@miss-islington @vstinner
[3.12] gh-114107: test.pythoninfo logs Windows Developer Mode (GH-114121
1d5bca6 
) (#114129)

gh-114107: test.pythoninfo logs Windows Developer Mode (GH-114121)

Also, don't skip the whole collect_windows() if ctypes is missing.

Log also ctypes.windll.shell32.IsUserAnAdmin().
(cherry picked from commit c77f552)

Co-authored-by: Victor Stinner <[email protected]>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@vstinner @kulikjak
pythongh-114107: test.pythoninfo logs Windows Developer Mode (python#…
f68e8ba 
…114121)

Also, don't skip the whole collect_windows() if ctypes is missing.

Log also ctypes.windll.shell32.IsUserAnAdmin().
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-114107: test.pythoninfo logs Windows Developer Mode (python#…
9189996 
…114121)

Also, don't skip the whole collect_windows() if ctypes is missing.

Log also ctypes.windll.shell32.IsUserAnAdmin().
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-114107: test.pythoninfo logs Windows Developer Mode (python#…
52b1664 
…114121)

Also, don't skip the whole collect_windows() if ctypes is missing.

Log also ctypes.windll.shell32.IsUserAnAdmin().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.