GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114070: fix token reference warnings in expressions.rst by skirpichev · Pull Request #114169 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Jan 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See #114070 (comment). The rest of mentioned warnings is related to the match statement. I think it worth a separate issue: #114172

  • Issue: Floating point syntax specification is incorrect #114070

📚 Documentation preview 📚: https://cpython-previews--114169.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-114070: fix token reference warnings in expressions.rst
376323c
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Jan 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 17, 2024
Floating point syntax specification is incorrect #114070
Closed
hugovk
hugovk approved these changes Jan 17, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 17, 2024
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 17, 2024
@hugovk
hugovk merged commit 029ecee into python:main Jan 17, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 17, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 17, 2024
@skirpichev @miss-islington
pythongh-114070: fix token reference warnings in expressions.rst (pyt…
1b385ab 
…honGH-114169)

(cherry picked from commit 029ecee)

Co-authored-by: Sergey B Kirpichev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 17, 2024
@skirpichev @miss-islington
pythongh-114070: fix token reference warnings in expressions.rst (pyt…
a2a3769 
…honGH-114169)

(cherry picked from commit 029ecee)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

GH-114192 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 17, 2024
@bedevere-app

bedevere-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

GH-114193 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 17, 2024
hugovk pushed a commit that referenced this pull request Jan 17, 2024
@miss-islington @skirpichev
[3.12] gh-114070: fix token reference warnings in expressions.rst (GH…
74a6b7f 
…-114169) (#114192)

Co-authored-by: Sergey B Kirpichev <[email protected]>
hugovk pushed a commit that referenced this pull request Jan 17, 2024
@miss-islington @skirpichev
[3.11] gh-114070: fix token reference warnings in expressions.rst (GH…
654c70a 
…-114169) (#114193)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@skirpichev
skirpichev deleted the fix-tokens1-114070 branch January 18, 2024 00:43
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@skirpichev @kulikjak
pythongh-114070: fix token reference warnings in expressions.rst (pyt…
3c1a8e6 
…hon#114169)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@skirpichev @aisk
pythongh-114070: fix token reference warnings in expressions.rst (pyt…
4c7772e 
…hon#114169)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@skirpichev @Glyphack
pythongh-114070: fix token reference warnings in expressions.rst (pyt…
0a6c106 
…hon#114169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@skirpichev @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.