GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) by perrinjerome · Pull Request #114173 · python/cpython

Conversation

@perrinjerome

@perrinjerome perrinjerome commented Jan 17, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 04fabe2)

Adjusted for 3.12, because exception printing also happens in C code.

  • Issue: Exception with broken __getattr__ causes error rendering tracebacks #113358

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Jan 17, 2024
Exception with broken __getattr__ causes error rendering tracebacks #113358
Closed
@perrinjerome perrinjerome changed the title gh-113358: Fix rendering tracebacks with exceptions with a broken __g…etattr__ (GH-113359) gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) Jan 17, 2024
@AlexWaygood AlexWaygood changed the title gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) [3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) Jan 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 17, 2024
gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ #113359
Merged
@perrinjerome
perrinjerome force-pushed the backport-04fabe2-3.12 branch from ed7e67b to 30964d1 Compare January 20, 2024 04:48
@perrinjerome @iritkatriel
[3.12] pythongh-113358: Fix rendering tracebacks with exceptions with…
3588252 
… a broken __getattr__ (pythonGH-113359)

(cherry picked from commit 04fabe2)

Co-authored-by: Jérome Perrin <[email protected]>
Co-authored-by: Irit Katriel <[email protected]>
@perrinjerome
perrinjerome force-pushed the backport-04fabe2-3.12 branch from 30964d1 to 3588252 Compare January 20, 2024 05:14
@perrinjerome
perrinjerome marked this pull request as ready for review January 20, 2024 05:35
@perrinjerome
perrinjerome requested a review from iritkatriel as a code owner January 20, 2024 05:35
@bedevere-app bedevere-app Bot added the awaiting review label Jan 20, 2024
@perrinjerome

perrinjerome commented Jan 20, 2024

Copy link
Copy Markdown
Contributor Author

@iritkatriel this is for 3.12 ,is it better to use PyErr_GetRaisedException as mentionned on
https://github.com/python/cpython/pull/114118/files#r1455635968 or to keep the same code as for 3.11 ? This version uses the same code as 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2024
@bedevere-bot

bedevere-bot commented Jan 20, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 3588252 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2024
@iritkatriel

iritkatriel commented Jan 20, 2024

Copy link
Copy Markdown
Member

@iritkatriel this is for 3.12 ,is it better to use PyErr_GetRaisedException as mentionned on https://github.com/python/cpython/pull/114118/files#r1455635968 or to keep the same code as for 3.11 ? This version uses the same code as 3.11

We can leave it the same. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed Jan 20, 2024
View reviewed changes
Comment thread Python/pythonrun.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@perrinjerome
Normalize exception
f0185e3
@perrinjerome perrinjerome mentioned this pull request Jan 21, 2024
[3.11] gh-113358 Fix rendering tracebacks with exceptions with a broken __getattr__ : Normalize exception #114379
Merged
iritkatriel
iritkatriel approved these changes Jan 21, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 21, 2024
@iritkatriel
iritkatriel merged commit 00e8c9c into python:3.12 Jan 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 21, 2024
@Eclips4 Eclips4 mentioned this pull request Jan 21, 2024
[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) #114105
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@perrinjerome @bedevere-bot @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.