GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-113358 Fix rendering tracebacks with exceptions with a broken __getattr__ : Normalize exception by perrinjerome · Pull Request #114379 · python/cpython

Conversation

@perrinjerome

@perrinjerome perrinjerome commented Jan 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

During review of #114173 we found out
that a call to PyErr_NormalizeException was missing after PyErr_Fetch.

These are changes that were missing from #114118

  • Issue: Exception with broken __getattr__ causes error rendering tracebacks #113358

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@perrinjerome
[3.11] Normalize exception
fe32493 
(cherry picked from commit f0185e3)

Co-authored-by: Jérome Perrin <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Jan 21, 2024
Exception with broken __getattr__ causes error rendering tracebacks #113358
Closed
@perrinjerome perrinjerome changed the title gh-113358 [3.11] Fix rendering tracebacks with exceptions with a broken __getattr__ : Normalize exception [3.11] gh-113358 Fix rendering tracebacks with exceptions with a broken __getattr__ : Normalize exception Jan 21, 2024
@perrinjerome perrinjerome mentioned this pull request Jan 21, 2024
[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) #114173
Merged
@perrinjerome
perrinjerome marked this pull request as ready for review January 21, 2024 10:25
@perrinjerome
perrinjerome requested a review from iritkatriel as a code owner January 21, 2024 10:25
@bedevere-app bedevere-app Bot added the awaiting review label Jan 21, 2024
iritkatriel
iritkatriel approved these changes Jan 21, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 21, 2024
@iritkatriel iritkatriel added the skip news label Jan 21, 2024
@iritkatriel
Merge branch '3.11' into backport-f0185e3-3.11
f0a7099
@iritkatriel
iritkatriel enabled auto-merge (squash) January 21, 2024 17:12
@iritkatriel
iritkatriel merged commit 3bd4c3a into python:3.11 Jan 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 21, 2024
@Eclips4 Eclips4 mentioned this pull request Jan 21, 2024
[3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) #114109
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@perrinjerome @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.