GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112087: Remove duplicated critical_section by corona10 · Pull Request #114268 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jan 18, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make list objects thread-safe in --disable-gil builds #112087

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-112087: Remove duplicated critical_section
c40c59f
@corona10
corona10 requested a review from colesbury January 18, 2024 22:34
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 18, 2024
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks done
@corona10 corona10 added the skip news label Jan 18, 2024
@corona10 corona10 changed the title gh-112087: Remove duplicated critical_section [WIP] gh-112087: Remove duplicated critical_section Jan 18, 2024
corona10 added 2 commits January 19, 2024 07:36
@corona10
fix
ed0ea4b
@corona10
fix
2d0dd6a
@corona10 corona10 changed the title [WIP] gh-112087: Remove duplicated critical_section gh-112087: Remove duplicated critical_section Jan 18, 2024
@corona10
Build fix
1454d7f
@corona10

corona10 commented Jan 18, 2024

Copy link
Copy Markdown
Member Author

Revert to the original code: https://github.com/python/cpython/pull/113863/files
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 closed this Jan 18, 2024
@corona10 corona10 reopened this Jan 18, 2024
colesbury
colesbury approved these changes Jan 18, 2024
View reviewed changes
@corona10
corona10 enabled auto-merge (squash) January 18, 2024 22:41
@corona10
corona10 merged commit d544285 into python:main Jan 18, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 18, 2024
@corona10 corona10 added the topic-free-threading label Jan 18, 2024
@corona10
corona10 deleted the gh-112087-fix branch January 18, 2024 23:03
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@corona10 @kulikjak
pythongh-112087: Remove duplicated critical_section (pythongh-114268)
4ac00ec
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10 @aisk
pythongh-112087: Remove duplicated critical_section (pythongh-114268)
7b42cb8
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10 @Glyphack
pythongh-112087: Remove duplicated critical_section (pythongh-114268)
ea93f48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.