GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114281: Remove incorrect type hints from `asyncio.staggered` by sobolevn · Pull Request #114282 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jan 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: asyncio.staggered has incorrect type hints #114281

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-114281: Improve type hints in asyncio/staggered.py
7206e41
@sobolevn
sobolevn requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners January 19, 2024 09:06
@bedevere-app bedevere-app Bot added the awaiting review label Jan 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 19, 2024
asyncio.staggered has incorrect type hints #114281
Closed
gvanrossum
gvanrossum reviewed Jan 20, 2024
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I don't want to maintain type annotations in stdlib modules unless we run mypy in CI. Maybe we should just remove these rather than try to fix them?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@sobolevn
Remove type annotations from asyncio.staggered
2ea1eda
@sobolevn

sobolevn commented Jan 20, 2024

Copy link
Copy Markdown
Member Author

Sure, typeshed has the correct version anyway 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner
AA-Turner approved these changes Jan 20, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 20, 2024
AA-Turner
AA-Turner reviewed Jan 20, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-01-19-12-05-22.gh-issue-114281.H5JQe4.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn @AA-Turner
Update Misc/NEWS.d/next/Library/2024-01-19-12-05-22.gh-issue-114281.H…
81f0ab8 
…5JQe4.rst

Co-authored-by: Adam Turner <[email protected]>
@AA-Turner AA-Turner changed the title gh-114281: Improve type hints in asyncio/staggered.py gh-114281: Remove incorrect type hints from asyncio.staggered Jan 20, 2024
gvanrossum
gvanrossum approved these changes Jan 20, 2024
View reviewed changes
@AA-Turner
AA-Turner merged commit 0554a95 into python:main Jan 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 20, 2024
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@sobolevn @AA-Turner @kulikjak
pythongh-114281: Remove incorrect type hints from asyncio.staggered (…
5195dc2 
…python#114282)

Co-authored-by: Adam Turner <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @AA-Turner @aisk
pythongh-114281: Remove incorrect type hints from asyncio.staggered (…
f4dbfb7 
…python#114282)

Co-authored-by: Adam Turner <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 17, 2024
asyncio.staggered is missing typing import #119121
Closed
@sobolevn sobolevn mentioned this pull request May 19, 2024
gh-119121: Fix and test async.staggered.staggered_race #119173
Merged
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @AA-Turner @Glyphack
pythongh-114281: Remove incorrect type hints from asyncio.staggered (…
d0754cf 
…python#114282)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @gvanrossum @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.