GeezerVison is showing github.com — gh-108303: Remove the non-test `Lib/test/reperf.py` by sobolevn · Pull Request #114356 · python/cpython
Conversation
sobolevn
commented
Jan 20, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently test_embed.py runs this code?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Ok, looks like it was used recently in #110769 by @ambv
I think that this has nothing to do with reperf, it just needs any rather complex module.
I propose to:
- replace
test_embed's code to generate the module from code, so it would have no depedencies
- still remove this module, we are cleaning things up, aren't we? :)
|
gpshead reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I am now using another file instead of reperf, it is already used in test_embed and is useful for this test as well: it prints the information, it has some imports, it does some checks.
So, we can remove the unneeded reperf 🎉
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd rather not backport the removal.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
sobolevn
commented
Sep 9, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@encukou looks like this PR #113601 influenced the CI. I fixed tests, so now both ./python.exe -m test test_embed and ./python.exe Lib/test/_test_embed_structseq.py pass:
» ./python.exe Lib/test/_test_embed_structseq.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.000s
OK
Tests passed
Please, take another look :)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|