GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove the non-test Lib/test/time_hashlib.py. by gpshead · Pull Request #114354 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Jan 20, 2024

Copy link
Copy Markdown
Member

I believe I added this while chasing some performance of hash functions when I first created hashlib. It hasn't been used since, is frankly trivial, and not a test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
Remove the non-test Lib/test/time_hashlib.py.
59e9d78 
I believe I added this while chasing some performance of hash functions
when I first created hashlib.  It hasn't been used since, is frankly
trivial, and not a test.
@gpshead
gpshead requested a review from tiran as a code owner January 20, 2024 19:42
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 20, 2024
@gpshead gpshead self-assigned this Jan 20, 2024
@gpshead gpshead added skip issue skip news labels Jan 20, 2024
@gpshead
gpshead requested review from serhiy-storchaka and removed request for tiran January 20, 2024 19:44
@gpshead
gpshead merged commit c48b8f8 into python:main Jan 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 20, 2024
@gpshead
gpshead deleted the remove_time_hashlib branch January 20, 2024 20:09
@hugovk hugovk mentioned this pull request Jan 20, 2024
Remove deleted time_hashlib.py from Lib/test/.ruff.toml #114355
Merged
@sobolevn sobolevn mentioned this pull request Jan 20, 2024
gh-108303: Remove the non-test Lib/test/reperf.py #114356
Merged
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@gpshead @kulikjak
Remove the non-test Lib/test/time_hashlib.py. (python#114354)
3216c8f 
I believe I added this while chasing some performance of hash functions
when I first created hashlib.  It hasn't been used since, is frankly
trivial, and not a test.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@gpshead @aisk
Remove the non-test Lib/test/time_hashlib.py. (python#114354)
ba993a8 
I believe I added this while chasing some performance of hash functions
when I first created hashlib.  It hasn't been used since, is frankly
trivial, and not a test.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@gpshead @Glyphack
Remove the non-test Lib/test/time_hashlib.py. (python#114354)
969949d 
I believe I added this while chasing some performance of hash functions
when I first created hashlib.  It hasn't been used since, is frankly
trivial, and not a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.