GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108303: Move `smtpd` to `test.support` by sobolevn · Pull Request #114368 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jan 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This module was removed from stdlib in #93246
But, since it is not really a test file, it should have been moved to Lib/test/support, not Lib/test. This PR fixes that :)

Now this is in line with asyncore and asynchat.

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-108303: Move stmpd to test.support
989fe35
@sobolevn
sobolevn requested review from arhadthedev and vstinner January 21, 2024 07:19
@sobolevn
sobolevn requested review from a team and vsajip as code owners January 21, 2024 07:19
@bedevere-app bedevere-app Bot added the awaiting review label Jan 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 21, 2024
Move test files into test subdirectories #108303
Closed
@sobolevn sobolevn added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 21, 2024
@AlexWaygood AlexWaygood changed the title gh-108303: Move stmpd to test.support gh-108303: Move smtpd to test.support Jan 21, 2024
vsajip
vsajip approved these changes Jan 21, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 21, 2024
@vstinner vstinner removed the needs backport to 3.11 only security fixes label Jan 22, 2024
@vstinner

vstinner commented Jan 22, 2024

Copy link
Copy Markdown
Member

This change should not be backported to 3.11: it was done in Python 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Jan 22, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_logging.py
from socketserver import (ThreadingUDPServer, DatagramRequestHandler,
ThreadingTCPServer, StreamRequestHandler)

with warnings.catch_warnings():

@vstinner vstinner Jan 22, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change removes with warnings.catch_warnings(): but apparently, it's useless. The test still pass without it:

$ ./python -Werror -m test test_logging test_smtplib -j0
Using random seed: 1598323201
0:00:00 load avg: 0.96 Run 2 tests in parallel using 2 worker processes
0:00:02 load avg: 1.37 [1/2] test_smtplib passed
0:00:18 load avg: 1.22 [2/2] test_logging passed

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 18.9 sec
Total tests: run=317 skipped=2
Total test files: run=2/2
Result: SUCCESS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit 8f5e7d7 into python:main Jan 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 22, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 22, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2024
@sobolevn @miss-islington
pythongh-108303: Move smtpd to test.support (pythonGH-114368)
3042305 
Update test_logging.py and test_smtplib.py.
(cherry picked from commit 8f5e7d7)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 22, 2024

Copy link
Copy Markdown

GH-114427 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 22, 2024
@vstinner

vstinner commented Jan 22, 2024

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner pushed a commit that referenced this pull request Jan 22, 2024
@miss-islington @sobolevn
[3.12] gh-108303: Move smtpd to test.support (GH-114368) (#114427)
58fdd15 
gh-108303: Move `smtpd` to `test.support` (GH-114368)

Update test_logging.py and test_smtplib.py.
(cherry picked from commit 8f5e7d7)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-108303: Move smtpd to test.support (python#114368)
b554d69 
Update test_logging.py and test_smtplib.py.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-108303: Move smtpd to test.support (python#114368)
73acfd9 
Update test_logging.py and test_smtplib.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes
@vstinner vstinner vstinner approved these changes
@arhadthedev arhadthedev Awaiting requested review from arhadthedev

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @vstinner @vsajip
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.