GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114364: Fix awkward wording about mmap.mmap.seekable being added by technillogue · Pull Request #114374 · python/cpython

Conversation

@technillogue

@technillogue technillogue commented Jan 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #114364. "it requires" is a little unclear and "method return the" is incorrect.

  • Issue: Awkward wording in GH-111835 whatsnew entry #114364

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@technillogue
Fix awkward wording about mmap.mmap.seekable being added
c76b9bd
@bedevere-app bedevere-app Bot added the awaiting review label Jan 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 21, 2024
Awkward wording in GH-111835 whatsnew entry #114364
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jan 21, 2024
Eclips4
Eclips4 reviewed Jan 21, 2024
View reviewed changes
Comment thread Misc/NEWS.d/3.13.0a2.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4
Add backticks
47ca259
@Eclips4
Eclips4 requested review from corona10 and terryjreedy January 22, 2024 06:49
@corona10
corona10 requested a review from AlexWaygood January 22, 2024 09:15
@corona10

corona10 commented Jan 22, 2024

Copy link
Copy Markdown
Member

@AlexWaygood Can you please take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Jan 23, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested @ericvsmith's wording from the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/3.13.0a2.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy and others added 2 commits February 1, 2024 00:56
@terryjreedy @erlend-aasland
Update Doc/whatsnew/3.13.rst
bfa5d7c 
Co-authored-by: Erlend E. Aasland <[email protected]>
@terryjreedy @erlend-aasland
Update Misc/NEWS.d/3.13.0a2.rst
b80b10c 
Co-authored-by: Erlend E. Aasland <[email protected]>
@terryjreedy

terryjreedy commented Feb 1, 2024

Copy link
Copy Markdown
Member

I merged Eric and Erland's suggestion and think this good enough. Will automerge and close issue.
technillogue reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy enabled auto-merge (squash) February 1, 2024 06:03
@terryjreedy
terryjreedy merged commit 5ce193e into python:main Feb 1, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 1, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@technillogue @Eclips4
@terryjreedy @erlend-aasland @aisk
pythongh-114364: Fix awkward wording about mmap.mmap.seekable (python…
23a684d 
…#114374)

---------
Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@Eclips4 Eclips4 Eclips4 left review comments
@corona10 corona10 Awaiting requested review from corona10
@terryjreedy terryjreedy Awaiting requested review from terryjreedy
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Awkward wording in GH-111835 whatsnew entry

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@technillogue @corona10 @terryjreedy @erlend-aasland @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.