GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113267: Revert "gh-106584: Fix exit code for unittest in Python 3.12 (#106588)" by serhiy-storchaka · Pull Request #114470 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 8fc0713.

  • Issue: Return the correct exit code if all tests have been skipped in unittest #106584
  • Issue: TestResult.stopTest called when test is skipped, despite TestResult.startTest not being called #113267

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
Revert "pythongh-106584: Fix exit code for unittest in Python 3.12 (p…
15d1968 
…ython#106588)"

This reverts commit 8fc0713.
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 23, 2024
Return the correct exit code if all tests have been skipped in unittest #106584
Closed
@serhiy-storchaka
serhiy-storchaka requested a review from gpshead January 23, 2024 08:59
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Jan 23, 2024
@serhiy-storchaka
Add a NEWS entry.
8d516f1
@serhiy-storchaka serhiy-storchaka changed the title Revert "gh-106584: Fix exit code for unittest in Python 3.12 (#106588)" gh-113267: Revert "gh-106584: Fix exit code for unittest in Python 3.12 (#106588)" Jan 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 23, 2024
TestResult.stopTest called when test is skipped, despite TestResult.startTest not being called #113267
Closed
@serhiy-storchaka
serhiy-storchaka merged commit ecabff9 into python:main Feb 4, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 4, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 4, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the revert-unittest-move-start-test branch February 4, 2024 15:27
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2024
@serhiy-storchaka @miss-islington
pythongh-113267: Revert "pythongh-106584: Fix exit code for unittest …
b79c37f 
…in Python 3.12 (pythonGH-106588)" (pythonGH-114470)

This reverts commit 8fc0713.
(cherry picked from commit ecabff9)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 4, 2024

Copy link
Copy Markdown

GH-114994 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 4, 2024
serhiy-storchaka added a commit that referenced this pull request Feb 4, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-113267: Revert "gh-106584: Fix exit code for unittest in Py…
0a73763 
…thon 3.12 (GH-106588)" (GH-114470) (GH-114994)

This reverts commit 8fc0713.
(cherry picked from commit ecabff9)

Co-authored-by: Serhiy Storchaka <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-113267: Revert "pythongh-106584: Fix exit code for unittest …
9d44784 
…in Python 3.12 (python#106588)" (pythonGH-114470)

This reverts commit 8fc0713.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@serhiy-storchaka @fsc-eriker
pythongh-113267: Revert "pythongh-106584: Fix exit code for unittest …
39378cc 
…in Python 3.12 (python#106588)" (pythonGH-114470)

This reverts commit 8fc0713.
@woodsp-ibm woodsp-ibm mentioned this pull request Feb 22, 2024
Add Python 3.12 support stfc/qiskit-machine-learning#774
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.