GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-91602: Add iterdump() support for filtering database objects. by felixxm · Pull Request #114501 · python/cpython

Conversation

felixxm commented Jan 23, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Docs changes.
More tests.
Release notes.

Issue: dump of a single table in sqlite3 library #91602

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

khemarato reacted with rocket emoji

All reactions

🚀 1 reaction

bedevere-app Bot mentioned this pull request

Jan 23, 2024

dump of a single table in sqlite3 library #91602

Closed

erlend-aasland reviewed

Jan 23, 2024

View reviewed changes

Comment thread

Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Jan 23, 2024

View reviewed changes

Comment thread

Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

felixxm force-pushed the issue-91602 branch from a03f298 to 46302ad Compare

January 24, 2024 04:35

erlend-aasland commented Jan 24, 2024

Copy link

Copy Markdown

Contributor

I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a full make regen-all, in order to generate the needed static string object for the filter keyword parameter.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          pythongh-91602: Add iterdump() support for filtering database objects.

bfad36a

felixxm force-pushed the issue-91602 branch from 46302ad to 9b6b649 Compare

January 24, 2024 08:01

felixxm commented Jan 24, 2024

Copy link

Copy Markdown

Contributor Author

I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a full make regen-all, in order to generate the needed static string object for the filter keyword parameter.

Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Jan 24, 2024

Copy link

Copy Markdown

Contributor

Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔.

Yeah, that's strange; I'd rebase onto main and make regen-all again 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Jan 24, 2024

Copy link

Copy Markdown

Contributor

BTW, can you please use git pull --noff main when aligning with main, instead of force pushing? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Jan 24, 2024

View reviewed changes

Comment thread

Lib/sqlite3/dump.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

felixxm added 2 commits

January 24, 2024 09:20


          Run regen-all.

c414251


          Fixed PyObject_Vectorcall() call and SQL placeholder.

b1ae087

felixxm force-pushed the issue-91602 branch from 9b6b649 to b1ae087 Compare

January 24, 2024 08:44

felixxm commented Jan 24, 2024

Copy link

Copy Markdown

Contributor Author

Thanks for all your help, much appreciated. I will work on tests and docs later today.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          More tests.

e181dcb

erlend-aasland reviewed

Jan 24, 2024

View reviewed changes

Comment thread

Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Added error handling for Py_*.

048a6a2

erlend-aasland reviewed

Jan 24, 2024

View reviewed changes

Comment thread

Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Jan 24, 2024

View reviewed changes

Comment thread

Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

felixxm added 2 commits

January 24, 2024 19:21


          Corrected error handling.

f09fa46


          Added docs and release notes.

f3bab47

felixxm changed the title ~~[WIP] gh-91602: Add iterdump() support for filtering database objects.~~ gh-91602: Add iterdump() support for filtering database objects.

Jan 24, 2024

felixxm marked this pull request as ready for review

January 24, 2024 19:52

felixxm requested a review from berkerpeksag as a code owner

January 24, 2024 19:52

bedevere-app Bot added the awaiting review label

Jan 24, 2024

felixxm commented Jan 24, 2024

Copy link

Copy Markdown

Contributor Author

Now it's ready for review 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Jan 24, 2024

View reviewed changes

Comment thread

Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Used Py_BuildValue().

321b3e0

erlend-aasland commented Jan 25, 2024

Copy link

Copy Markdown

Contributor

Very nice; 321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixxm commented Jan 25, 2024

Copy link

Copy Markdown

Contributor Author

Very nice; 321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :)

🍿

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          goto no longer needed.

8cf51d4

erlend-aasland reviewed

Jan 25, 2024

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refcout refactoring in 8cf51d4 is superb; I was just about to suggest it 🚀. I left a small comment regarding how we do the vector call.

When doing changes that affect reference counting, I normally do a refleak test locally:

$ ./python.exe -m test -R : test_sqlite3

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Used PyVectorcall_NARGS().

d993e11

erlend-aasland reviewed

Jan 25, 2024

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this final change, we should be ready to land.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Arguments offset.

4de91be

felixxm commented Jan 25, 2024

Copy link

Copy Markdown

Contributor Author

@erlend-aasland Thanks for all your help 🎁

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into issue-91602

2036d0a

erlend-aasland reviewed

Jan 26, 2024

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now for the docs; I left some comments :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2024-01-24-20-51-49.gh-issue-91602.8fOH8l.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Corrected docs.

e314153

erlend-aasland approved these changes

Jan 26, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jan 26, 2024

erlend-aasland commented Feb 3, 2024

Copy link

Copy Markdown

Contributor

!buildbot .refleak.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Feb 3, 2024

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit e314153 🤖

The command will test the builders whose names match following regular expression: .*refleak.*

The builders matched are:

aarch64 RHEL8 Refleaks PR
s390x RHEL8 Refleaks PR
AMD64 Windows11 Refleaks PR
AMD64 Ubuntu NoGIL Refleaks PR
AMD64 Fedora Stable Refleaks PR
ARM64 MacOS M1 Refleaks NoGIL PR
aarch64 Fedora Rawhide Refleaks PR
AMD64 Fedora Rawhide Refleaks PR
PPC64LE Fedora Rawhide Refleaks PR
s390x Fedora Refleaks PR
PPC64LE CentOS9 Refleaks PR
s390x Fedora Rawhide Refleaks PR
PPC64LE RHEL8 Refleaks PR
PPC64LE RHEL7 Refleaks PR
AMD64 CentOS9 Refleaks PR
PPC64LE Fedora Stable Refleaks PR
aarch64 Fedora Stable Refleaks PR
aarch64 CentOS9 Refleaks PR
AMD64 RHEL8 Refleaks PR
s390x RHEL7 Refleaks PR
AMD64 RHEL7 Refleaks PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Feb 6, 2024

Copy link

Copy Markdown

Contributor

The buildbot/s390x Fedora Rawhide Refleaks PR buildbot failure is unrelated to this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Pull in main and regen clinic

3c451df

erlend-aasland merged commit 1a10437 into python:main

Feb 6, 2024

bedevere-app Bot removed the awaiting merge label

Feb 6, 2024

erlend-aasland commented Feb 6, 2024

Copy link

Copy Markdown

Contributor

Thanks a lot, @felixxm!

felixxm reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixxm deleted the issue-91602 branch

February 6, 2024 12:05

fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request

Feb 14, 2024


          pythongh-91602: Add iterdump() support for filtering database objects (…

a973b4b

…python#114501)

Add optional 'filter' parameter to iterdump() that allows a "LIKE"
pattern for filtering database objects to dump.

Co-authored-by: Erlend E. Aasland <[email protected]>

Reviewers

erlend-aasland

erlend-aasland approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

felixxm commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Jan 24, 2024

Uh oh!

felixxm commented Jan 24, 2024

Uh oh!

erlend-aasland commented Jan 24, 2024

Uh oh!

erlend-aasland commented Jan 24, 2024

Uh oh!

Uh oh!

felixxm commented Jan 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixxm commented Jan 24, 2024

Uh oh!

Uh oh!

erlend-aasland commented Jan 25, 2024

Uh oh!

felixxm commented Jan 25, 2024

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

felixxm commented Jan 25, 2024

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Feb 3, 2024

Uh oh!

bedevere-bot commented Feb 3, 2024

Uh oh!

erlend-aasland commented Feb 6, 2024

Uh oh!

erlend-aasland commented Feb 6, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

felixxm commented Jan 23, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.