GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — gh-108303: Move all `pydoc` related files to `test_pydoc` by sobolevn · Pull Request #114506 · python/cpython Conversation
|
|
Very strange, why windows build fails. I will investigate. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Tell me if you need help to investigate. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
test_pydoc is failing! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
yes, this is expected. I am still debugging :( |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I will convert to draft, so it will be clear that this is a WIP. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Try: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Also, there are now merge conflicts. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
No, that's not the case :) I am trying to debug the initial Windows failure: The problem is that I cannot reproduce it locally on my macos. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
5d78f9f to
24e087b
Compare
|
You should update pydoc as well: diff --git a/Lib/pydoc.py b/Lib/pydoc.py index 17f7346e5c..6d145abda9 100755 --- a/Lib/pydoc.py +++ b/Lib/pydoc.py @@ -552,7 +552,7 @@ def getdocloc(self, object, basedir=sysconfig.get_path('stdlib')): '_thread', 'zipimport') or (file.startswith(basedir) and not file.startswith(os.path.join(basedir, 'site-packages')))) and - object.__name__ not in ('xml.etree', 'test.pydoc_mod')): + object.__name__ not in ('xml.etree', 'test.test_pydoc.pydoc_mod')): if docloc.startswith(("http://", "https://")): docloc = "{}/{}.html".format(docloc.rstrip("/"), object.__name__.lower()) else: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@vstinner thanks a lot, your suggestion about |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @sobolevn and @vstinner, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @sobolevn and @vstinner, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Merged. I just edited the commit message. Oh, sorry, I forgot that you can now merge changes by yourself! Oops. Well, sadly, automated backports fail as usual. Can you try to backport them manually? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Will do! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…t_pydoc` package (python#114506)
|
GH-115501 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-115502 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.