GeezerVison is showing github.com — gh-112075: Use PyMem_* for allocating dict keys objects by DinoV · Pull Request #114543 · python/cpython
Conversation
DinoV
commented
Jan 25, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Use PyMem_* for allocating dict keys objects
Currently dict keys are allocated using PyObject_Malloc. This isn't right for free-threaded builds because we don't want non-object allocations to overlap with the object heap. Doing so breaks the guarantees that we can apply an incref to a value which may have been freed and back it out if we lost the reference to the logic. This just switches the allocations to use PyMem_* instead.
This also eliminates some duplication by moving the decref into dictkeys_decref when the ref count drops to zero. This is the only place we need to do this, but the logic to move to the free list or free is currently duplicated. This will become a little more complex with QSBR so we may as well isolate it all to one spot.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on line 1546 should be updated, but otherwise lgtm
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
|
}
|
|
|
#endif
|
|
|
PyObject_Free(keys);
|
|
|
PyMem_Free(keys);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, @corona10 this might cause merge conflicts with #114323, but I don't think they'll be too difficult to resolve.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…#114543)
Use PyMem_* for keys allocation
Reviewers
methane
methane approved these changes
markshannon
Awaiting requested review from markshannon
markshannon is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|