GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112087: Make PyList_{Append,Size,GetSlice} to be thread-safe by corona10 · Pull Request #114651 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jan 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make list objects thread-safe in --disable-gil builds #112087

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-112087: Make PyList_{Append,GetItem,Size,GetSlice} to be thr…
393cbef 
…ead-safe
@corona10 corona10 added skip news topic-free-threading labels Jan 27, 2024
@corona10
corona10 requested review from DinoV and colesbury January 27, 2024 14:18
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 27, 2024
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks done
@corona10

corona10 commented Jan 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@colesbury

  • Py_SET_SIZE: Since Py_SET_SIZE is used for mutable collections, it is worth making it the atomic API.
  • PyList_Size: This API becomes the atomic API.
  • _Py_SET_ITEMREF is added: Too many patterns exist in the list object.c, worth adding it as the utility macro. But I'm not sure that it is located in the proper place.
  • PyList_Append, PyList_GetSlice becomes thread-safe.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 3 commits January 27, 2024 23:24
@corona10
Fix compiler warn
df1661d
@corona10
nit
6f37b61
@corona10
fix
f67f936
@corona10 corona10 changed the title gh-112087: Make PyList_{Append,GetItem,Size,GetSlice} to be thread-safe gh-112087: Make PyList_{Append,Size,GetSlice} to be thread-safe Jan 27, 2024
@corona10
Improve _PyList_AppendTakeRef
ba74dc5
corona10
corona10 commented Jan 27, 2024
View reviewed changes
Comment thread Objects/listobject.c
_PyList_AppendTakeRefListResize(PyListObject *self, PyObject *newitem)
{
Py_ssize_t len = PyList_GET_SIZE(self);
Py_ssize_t len = Py_SIZE(self);

@corona10 corona10 Jan 27, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only called by _PyList_AppendTakeRef, so it's safe.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
nit
9075e61
colesbury
colesbury reviewed Jan 29, 2024
View reviewed changes
Comment thread Objects/listobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/listobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/listobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
Address code review
553db97
@corona10
corona10 requested a review from colesbury January 30, 2024 01:10
colesbury
colesbury approved these changes Jan 31, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 merged commit 7b9d406 into python:main Jan 31, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 31, 2024
@corona10
corona10 deleted the gh-112087-append branch January 31, 2024 23:58
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10 @aisk
pythongh-112087: Make PyList_{Append,Size,GetSlice} to be thread-safe (…
287db96 
…pythongh-114651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@DinoV DinoV Awaiting requested review from DinoV

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.