GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112529: Simplify PyObject_GC_IsTracked and PyObject_GC_IsFinalized by colesbury · Pull Request #114732 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jan 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Simplifies the implementations of PyObject_GC_IsTracked() and PyObject_GC_IsFinalized() in the free-threaded build's GC. The _PyObject_IS_GC() check is not necessary because every object in the free-threaded build has an ob_gc_bits field.

This also simplifies the Python bindings in gcmodule.c.

  • Issue: Make the garbage collector thread-safe in --disable-gil builds #112529

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-112529: Simplify PyObject_GC_IsTracked and PyObject_GC_IsFin…
8cad9d7 
…alized

Simplifies the implementations of PyObject_GC_IsTracked() and
PyObject_GC_IsFinalized() in the free-threaded build's GC. The
_PyObject_IS_GC() check is not necessary because every object has an
ob_gc_bits fields.

This also simplifies the Python bindings in gcmodule.c.
@colesbury colesbury added the topic-free-threading label Jan 29, 2024
@colesbury
colesbury requested a review from nascheme January 29, 2024 20:43
@colesbury
colesbury requested a review from pablogsal as a code owner January 29, 2024 20:43
@bedevere-app bedevere-app Bot added the awaiting review label Jan 29, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 29, 2024
Make the garbage collector thread-safe in --disable-gil builds #112529
Closed
3 tasks
@colesbury colesbury added the skip news label Jan 29, 2024
@colesbury
colesbury requested a review from DinoV February 6, 2024 16:46
DinoV
DinoV approved these changes Feb 28, 2024
View reviewed changes

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 28, 2024
@colesbury
colesbury merged commit df5212d into python:main Feb 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 28, 2024
@colesbury
colesbury deleted the gh-112529-isgcobject branch February 28, 2024 20:38
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@colesbury @woodruffw
pythongh-112529: Simplify PyObject_GC_IsTracked and PyObject_GC_IsFin…
d988f63 
…alized (python#114732)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@colesbury @adorilson
pythongh-112529: Simplify PyObject_GC_IsTracked and PyObject_GC_IsFin…
7c6c093 
…alized (python#114732)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@colesbury @diegorusso
pythongh-112529: Simplify PyObject_GC_IsTracked and PyObject_GC_IsFin…
15c69a6 
…alized (python#114732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoV DinoV DinoV approved these changes
@nascheme nascheme Awaiting requested review from nascheme
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @DinoV
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.