GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ``importlib/_bootstrap.py``: Reduce size of ``_List`` instances by Eclips4 · Pull Request #114747 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Jan 30, 2024

Copy link
Copy Markdown
Member

Originally taken from: https://github.com/python/cpython/pull/108497/files#r1308572325

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
Reduce size of _List instances
978e421
@Eclips4 Eclips4 added skip issue skip news labels Jan 30, 2024
@Eclips4
Eclips4 requested review from Yhg1s and brettcannon January 30, 2024 09:19
@Eclips4
Eclips4 requested review from ericsnowcurrently, ncoghlan and warsaw as code owners January 30, 2024 09:19
@bedevere-app bedevere-app Bot added the awaiting review label Jan 30, 2024
@Eclips4
Eclips4 removed request for ericsnowcurrently, ncoghlan and warsaw January 30, 2024 09:19
@Eclips4

Eclips4 commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

This change prevents us from creating __dict__ for each instance of _Lock type.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon
brettcannon approved these changes Jan 30, 2024
View reviewed changes
Comment thread Lib/importlib/_bootstrap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 30, 2024
@brettcannon
brettcannon merged commit 6de8aa3 into python:main Jan 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 30, 2024
@Eclips4
Eclips4 deleted the reduce_list_size branch January 30, 2024 20:17
@Eclips4

Eclips4 commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

Since the initial fix (#108497) was backported to 3.12 branch, maybe it's makes sense to backport this patch as well?
@brettcannon @Yhg1s
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Eclips4 @aisk
importlib/_bootstrap.py: Reduce size of _List instances (pyth…
d9157c3 
…onGH-114747)

Reduce size of _List instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Eclips4 @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.