GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114737: Revert change to ElementTree.iterparse "root" attribute by colesbury · Pull Request #114755 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jan 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Prior to gh-114269, the iterator returned by ElementTree.iterparse was initialized with the root attribute as None. This restores the previous behavior.

Thanks to Prometheus3375 for pointing this out.

  • Issue: Fix unintended behavior change in elementtree introduced in #114269 #114737

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-114737: Revert change to ElementTree.iterparse "root" attribute
212ef9f 
Prior to pythongh-114269, the iterator returned by ElementTree.iterparse was
initialized with the root attribute as None. This restores the previous
behavior.
@colesbury
colesbury requested a review from serhiy-storchaka January 30, 2024 18:09
@bedevere-app bedevere-app Bot mentioned this pull request Jan 30, 2024
Fix unintended behavior change in elementtree introduced in #114269 #114737
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jan 30, 2024
@colesbury

colesbury commented Jan 30, 2024

Copy link
Copy Markdown
Contributor Author

cc @Prometheus3375
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury colesbury added the skip news label Jan 30, 2024
serhiy-storchaka
serhiy-storchaka reviewed Jan 30, 2024
View reviewed changes
Comment thread Lib/test/test_xml_etree.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury @serhiy-storchaka
Update Lib/test/test_xml_etree.py
8d4f5b3 
Co-authored-by: Serhiy Storchaka <[email protected]>
Prometheus3375
Prometheus3375 reviewed Jan 30, 2024
View reviewed changes
Comment thread Lib/xml/etree/ElementTree.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Jan 30, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 30, 2024
@colesbury
Remove del statement
a2ebd83
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 31, 2024
@serhiy-storchaka
serhiy-storchaka merged commit 66f95ea into python:main Jan 31, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 31, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 31, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2024
@colesbury @miss-islington
pythongh-114737: Revert change to ElementTree.iterparse "root" attrib…
8ebd614 
…ute (pythonGH-114755)

Prior to pythongh-114269, the iterator returned by ElementTree.iterparse was
initialized with the root attribute as None. This restores the previous
behavior.
(cherry picked from commit 66f95ea)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 31, 2024

Copy link
Copy Markdown

GH-114798 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2024
@colesbury @miss-islington
pythongh-114737: Revert change to ElementTree.iterparse "root" attrib…
e842682 
…ute (pythonGH-114755)

Prior to pythongh-114269, the iterator returned by ElementTree.iterparse was
initialized with the root attribute as None. This restores the previous
behavior.
(cherry picked from commit 66f95ea)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 31, 2024
@bedevere-app

bedevere-app Bot commented Jan 31, 2024

Copy link
Copy Markdown

GH-114799 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 31, 2024
serhiy-storchaka pushed a commit that referenced this pull request Jan 31, 2024
@miss-islington @colesbury
[3.12] gh-114737: Revert change to ElementTree.iterparse "root" attri…
5d7b90d 
…bute (GH-114755) (GH-114798)

Prior to gh-114269, the iterator returned by ElementTree.iterparse was
initialized with the root attribute as None. This restores the previous
behavior.
(cherry picked from commit 66f95ea)

Co-authored-by: Sam Gross <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Jan 31, 2024
@miss-islington @colesbury
[3.11] gh-114737: Revert change to ElementTree.iterparse "root" attri…
3982049 
…bute (GH-114755) (GH-114799)

Prior to gh-114269, the iterator returned by ElementTree.iterparse was
initialized with the root attribute as None. This restores the previous
behavior.
(cherry picked from commit 66f95ea)

Co-authored-by: Sam Gross <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@colesbury @aisk
pythongh-114737: Revert change to ElementTree.iterparse "root" attrib…
d23850c 
…ute (pythonGH-114755)

Prior to pythongh-114269, the iterator returned by ElementTree.iterparse was
initialized with the root attribute as None. This restores the previous
behavior.
@colesbury
colesbury deleted the gh-114737 branch April 8, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
+1 more reviewer
@Prometheus3375 Prometheus3375 Prometheus3375 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @serhiy-storchaka @Prometheus3375
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.