GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106392: Fix inconsistency in deprecation warnings in datetime module by serhiy-storchaka · Pull Request #114761 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: datetime UTC deprecation warnings use the name "datetime" inconsistently #106392

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-106392: Fix inconsistency in deprecation warnings in datetim…
5da2081 
…e module
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.12 only security fixes labels Jan 30, 2024
@serhiy-storchaka
serhiy-storchaka requested review from abalkin and pganssle as code owners January 30, 2024 20:37
@bedevere-app bedevere-app Bot mentioned this pull request Jan 30, 2024
datetime UTC deprecation warnings use the name "datetime" inconsistently #106392
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 30, 2024
@AlexWaygood AlexWaygood mentioned this pull request Jan 30, 2024
gh-106392: Fix consistency in pydatetime error messages #114764
Closed
hauntsaninja
hauntsaninja reviewed Jan 30, 2024
View reviewed changes
Comment thread Lib/_pydatetime.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka @hauntsaninja
Update Lib/_pydatetime.py
f94c231 
Co-authored-by: Shantanu <[email protected]>
hauntsaninja
hauntsaninja approved these changes Jan 30, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 30, 2024
@hauntsaninja

hauntsaninja commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Thank you for fixing!
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) January 30, 2024 21:36
@serhiy-storchaka

serhiy-storchaka commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

Thank you for your review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit dc4cd2c into python:main Jan 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 30, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 30, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2024
@serhiy-storchaka @miss-islington
pythongh-106392: Fix inconsistency in deprecation warnings in datetim…
b5b543d 
…e module (pythonGH-114761)

(cherry picked from commit dc4cd2c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 30, 2024

Copy link
Copy Markdown

GH-114767 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 30, 2024
hauntsaninja pushed a commit that referenced this pull request Jan 31, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-106392: Fix inconsistency in deprecation warnings in dateti…
2e8417e 
…me module (GH-114761) (#114767)

gh-106392: Fix inconsistency in deprecation warnings in datetime module (GH-114761)
(cherry picked from commit dc4cd2c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka deleted the datetime-warns branch January 31, 2024 11:17
@neutrinoceros neutrinoceros mentioned this pull request Feb 10, 2024
clarify distinction between datetime module and class in deprecation messages (again) #109080
Closed
@neutrinoceros

neutrinoceros commented Feb 10, 2024

Copy link
Copy Markdown
Contributor

For reference, this PR was a dupe to #109080 , but I understand it's hard to keep track of everything. Thanks for fixing it !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-106392: Fix inconsistency in deprecation warnings in datetim…
013488b 
…e module (pythonGH-114761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @hauntsaninja @neutrinoceros
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.